Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SentryClient constructor public #4045

Merged
merged 3 commits into from
Jan 14, 2025
Merged

Conversation

adinauer
Copy link
Member

📜 Description

Make SentryClient constructor public

💡 Motivation and Context

So we can support https://docs.sentry.io/platforms/android/configuration/shared-environments/ for v8

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Jan 14, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 95f88cc

Copy link
Contributor

github-actions bot commented Jan 14, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 480.76 ms 574.90 ms 94.14 ms
Size 1.65 MiB 2.31 MiB 677.53 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
00c8eeb 415.32 ms 428.08 ms 12.76 ms

App size

Revision Plain With Sentry Diff
00c8eeb 1.70 MiB 2.36 MiB 671.98 KiB

Previous results on branch: feat/sentry-client-public-ctor

Startup times

Revision Plain With Sentry Diff
1a0280c 404.24 ms 432.78 ms 28.53 ms

App size

Revision Plain With Sentry Diff
1a0280c 1.65 MiB 2.31 MiB 677.51 KiB

@adinauer adinauer merged commit 46f1597 into main Jan 14, 2025
37 of 38 checks passed
@adinauer adinauer deleted the feat/sentry-client-public-ctor branch January 14, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants