Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graphql 22 update instrumentation #3974

Merged
merged 4 commits into from
Dec 17, 2024

Conversation

lbloder
Copy link
Collaborator

@lbloder lbloder commented Dec 9, 2024

📜 Description

Replace deprecated SimpleInstrumentation with SimplePerformantInstrumentation in sentry-graphql-22.

💡 Motivation and Context

Fixes #3968

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Dec 9, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against c710bc2

@lbloder lbloder marked this pull request as ready for review December 16, 2024 08:36
Copy link
Contributor

github-actions bot commented Dec 16, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 439.48 ms 466.76 ms 27.28 ms
Size 1.65 MiB 2.31 MiB 676.08 KiB

Previous results on branch: feat/graphql-22-update-instrumentation

Startup times

Revision Plain With Sentry Diff
5fb3d91 684.17 ms 766.98 ms 82.81 ms

App size

Revision Plain With Sentry Diff
5fb3d91 1.65 MiB 2.31 MiB 676.08 KiB

Copy link
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lbloder lbloder merged commit eac1c49 into 8.x.x Dec 17, 2024
29 of 30 checks passed
@lbloder lbloder deleted the feat/graphql-22-update-instrumentation branch December 17, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants