Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POTEL 61 - Tracing without Performance defer sampling decision #3945

Merged
merged 13 commits into from
Dec 2, 2024

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Dec 2, 2024

📜 Description

Defer sampling decision by setting null for sampled in PropagationContext when using OpenTelemetry.

💡 Motivation and Context

This is one part for making Tracing without Performance work with OpenTelemetry

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Dec 2, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 9ab5b87

Copy link
Contributor

github-actions bot commented Dec 2, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 417.92 ms 454.02 ms 36.10 ms
Size 1.65 MiB 2.31 MiB 676.08 KiB

Previous results on branch: feat/potel-61-twp-sampling-decision

Startup times

Revision Plain With Sentry Diff
45d893d 406.87 ms 446.38 ms 39.51 ms

App size

Revision Plain With Sentry Diff
45d893d 1.65 MiB 2.31 MiB 676.07 KiB

Base automatically changed from feat/fix-twp to 8.x.x December 2, 2024 14:17
Copy link
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@adinauer adinauer merged commit 53bf61a into 8.x.x Dec 2, 2024
27 of 30 checks passed
@adinauer adinauer deleted the feat/potel-61-twp-sampling-decision branch December 2, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants