-
-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace GraphQlSourceBuilderCustomizer
with directly providing a SentryInstrumenter
bean if missing
#3744
Replace GraphQlSourceBuilderCustomizer
with directly providing a SentryInstrumenter
bean if missing
#3744
Conversation
…d sentry-graphql-core
…ryInstrumentation bean if missing
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Replace `GraphQlSourceBuilderCustomizer` with directly providing a `SentryInstrumenter` bean if missing ([#3744](https://github.com/getsentry/sentry-java/pull/3744)) If none of the above apply, you can opt out of this check by adding |
} | ||
|
||
@Bean | ||
@Bean(name = "sentryInstrumentation") | ||
@ConditionalOnMissingBean(name = "sentryInstrumentation") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should change this to not rely on the bean name but rather the type SentryInstrumentation
regardless of name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍, after the @ConditionalOnMissingBean()
annotations have been changed to rely on type instead of name
Performance metrics 🚀
|
📜 Description
We now provide a
SentryInstrumenter
bean directly if there is none yet instead of usingGraphQlSourceBuilderCustomizer
to add the instrumentation.It is now also possible to provide a bean of type
SentryGraphqlInstrumentation.BeforeSpanCallback
which is then used bySentryInstrumenter
, e.g.:💡 Motivation and Context
Closes #3412
💚 How did you test it?
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps