Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove internal annotation on SpanOptions #3722

Merged
merged 7 commits into from
Sep 30, 2024

Conversation

adinauer
Copy link
Member

📜 Description

SpanOptions can't be internal since TransactionOptions is a subclass and is not marked internal.

💡 Motivation and Context

Closes #3639

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@adinauer adinauer changed the base branch from main to feat/non-nullable-trace-context September 26, 2024 04:26
Copy link
Contributor

github-actions bot commented Sep 26, 2024

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Remove internal annotation on `SpanOptions` ([#3722](https://github.com/getsentry/sentry-java/pull/3722))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 1cec319

Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

Base automatically changed from feat/non-nullable-trace-context to 8.x.x September 30, 2024 07:31
An error occurred while trying to automatically change base from feat/non-nullable-trace-context to 8.x.x September 30, 2024 07:31
@adinauer adinauer merged commit 356b5ce into 8.x.x Sep 30, 2024
3 of 4 checks passed
@adinauer adinauer deleted the feat/span-options-non-internal branch September 30, 2024 07:34
Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 513.96 ms 530.54 ms 16.58 ms
Size 1.70 MiB 2.35 MiB 669.06 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Access Modifier For Transaction.UpdateStartDate Public
2 participants