Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POTEL 49 - Add enable-spotlight and spotlight-connection-url to external options and check if enabled in OTel #3709

Merged
merged 13 commits into from
Sep 23, 2024

Conversation

adinauer
Copy link
Member

📜 Description

  • Add enable-spotlight and spotlight-connection-url to external options
  • Check if spotlight is enabled when deciding whether to inspect an OpenTelemetry span for connecting to splotlight

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Sep 23, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 574b3bb

Copy link
Contributor

github-actions bot commented Sep 23, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 417.35 ms 485.70 ms 68.34 ms
Size 1.70 MiB 2.35 MiB 667.35 KiB

Previous results on branch: feat/spotlight-config-otel-check

Startup times

Revision Plain With Sentry Diff
bd69a6f 377.67 ms 441.24 ms 63.57 ms

App size

Revision Plain With Sentry Diff
bd69a6f 1.70 MiB 2.35 MiB 667.35 KiB

Copy link
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Base automatically changed from feat/cleanup-potel-todos to 8.x.x September 23, 2024 12:56
An error occurred while trying to automatically change base from feat/cleanup-potel-todos to 8.x.x September 23, 2024 12:56
@adinauer adinauer merged commit 8bab428 into 8.x.x Sep 23, 2024
12 of 21 checks passed
@adinauer adinauer deleted the feat/spotlight-config-otel-check branch September 23, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants