Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POTEL 35 - Use OtelSpan name as fallback for transaction name #3557

Merged
merged 4 commits into from
Jul 11, 2024

Conversation

lbloder
Copy link
Collaborator

@lbloder lbloder commented Jul 9, 2024

📜 Description

Fallback to otelspan name as transaction description if sentry span description is null

💡 Motivation and Context

Avoid having <unlabeled transaction> as label in sentry.

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Jul 9, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 29d1993

Copy link
Contributor

github-actions bot commented Jul 9, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 473.74 ms 584.28 ms 110.54 ms
Size 1.70 MiB 2.29 MiB 599.31 KiB

Baseline results on branch: 8.x.x

Startup times

Revision Plain With Sentry Diff
a0f7731 357.02 ms 433.40 ms 76.38 ms
2f49b9c 416.54 ms 479.14 ms 62.60 ms
a59fca2 560.08 ms 658.80 ms 98.71 ms
57732e8 435.66 ms 510.50 ms 74.84 ms
ca82680 490.88 ms 631.67 ms 140.80 ms
41e496a 408.90 ms 491.32 ms 82.42 ms

App size

Revision Plain With Sentry Diff
a0f7731 1.70 MiB 2.29 MiB 599.77 KiB
2f49b9c 1.70 MiB 2.29 MiB 599.31 KiB
a59fca2 1.70 MiB 2.29 MiB 599.77 KiB
57732e8 1.70 MiB 2.29 MiB 599.77 KiB
ca82680 1.70 MiB 2.29 MiB 599.31 KiB
41e496a 1.70 MiB 2.29 MiB 599.77 KiB

Previous results on branch: feat/POTEL-35-Transaction-Name-Fallback

Startup times

Revision Plain With Sentry Diff
006be01 408.35 ms 486.96 ms 78.61 ms

App size

Revision Plain With Sentry Diff
006be01 1.70 MiB 2.29 MiB 599.31 KiB

Copy link
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just needs a changelog entry

@adinauer adinauer marked this pull request as ready for review July 11, 2024 07:57
@adinauer adinauer merged commit aaf7418 into 8.x.x Jul 11, 2024
23 checks passed
@adinauer adinauer deleted the feat/POTEL-35-Transaction-Name-Fallback branch July 11, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants