-
-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed user segment #3512
removed user segment #3512
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@markushi I'm confused, where's the problems with merging? |
We have two PRs:
But since 2. isn't built on top of 1., all the changes in this PR will cause a merge conflict once 1. is merged into main and 8.x.x |
I see what you mean. To me it's fine to wait a while before merging it. |
Should be fine to merge, just watch out when merging |
# Conflicts: # sentry/src/main/java/io/sentry/Baggage.java # sentry/src/main/java/io/sentry/TraceContext.java # sentry/src/main/java/io/sentry/protocol/User.java
i updated this PR after merging master into v8 branch. |
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
57732e8 | 435.66 ms | 510.50 ms | 74.84 ms |
a0f7731 | 357.02 ms | 433.40 ms | 76.38 ms |
41e496a | 408.90 ms | 491.32 ms | 82.42 ms |
a59fca2 | 560.08 ms | 658.80 ms | 98.71 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
57732e8 | 1.70 MiB | 2.29 MiB | 599.77 KiB |
a0f7731 | 1.70 MiB | 2.29 MiB | 599.77 KiB |
41e496a | 1.70 MiB | 2.29 MiB | 599.77 KiB |
a59fca2 | 1.70 MiB | 2.29 MiB | 599.77 KiB |
# Conflicts: # CHANGELOG.md
📜 Description
💡 Motivation and Context
Closes #3497
💚 How did you test it?
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps