-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document Apollo3 GraphQL client errors #7135
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
efbd5cb
Document Apollo3 GraphQL client errors
marandaneto 0ccc1d2
fix
marandaneto 2235724
add grouping note
marandaneto cfe2208
Update src/platforms/android/configuration/integrations/apollo3.mdx
marandaneto 2def437
Update src/platforms/android/configuration/integrations/apollo3.mdx
marandaneto d264bb1
Update src/platforms/android/configuration/integrations/apollo3.mdx
marandaneto 1ba2035
Update src/platforms/android/configuration/integrations/apollo3.mdx
marandaneto b9d9c1a
Update src/platforms/android/configuration/integrations/apollo3.mdx
marandaneto 8218c37
Update src/platforms/android/configuration/integrations/apollo3.mdx
marandaneto 7da4eaa
Update src/platforms/android/configuration/integrations/apollo3.mdx
marandaneto 5a0123e
Use correct license identifer in package.json (#7141)
cleptric ec90a51
Add hint about electron SDK version in source maps troubleshooting do…
lforst 230e395
Bump API schema to f88c7be1 (#7146)
getsentry-release 7790df5
Fix: Move team plan banner for metric alerts (#7147)
vivianyentran 3191a86
add redirects for sourcemaps best practices (#7148)
shanamatthews 23dcbcd
Add redirects (#7149)
shanamatthews 26fe322
Remove link to Apple debug symbols (#7142)
kahest 5c51859
Add React Router Info to Onboarding Wizard (#7136)
ale-cota 5bd1813
Re-add troubleshooting guide for legacy source map upload (#7126)
lforst b27558c
Restore troubleshooting sourcemaps docs for platforms that support de…
lforst 466c281
Add iOS source context info to RN debug symbols page (#7143)
krystofwoldrich c14aaea
fix
marandaneto f7cd85a
Add Apple Debug Symbols Sentry CLI link to RN manual setup page (#7151)
krystofwoldrich bd9f68e
Merge branch 'master' into chore/apollo3-graphql-errors
marandaneto File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
m
: is there a reason why we use a different snippet here than below?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just did indentation here, the code already exists, not sure I follow the question.
There's a difference between Kotlin vs Java as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh right, you only need
SentryApolloBuilderExtensionsKt
on Java, and the snippets below are only in Kotlin, sorry for the confusion. Should we add Java snippets for client errors as well?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest, I think we should go Kotlin first and only, less to maintain, nowadays IDEs auto convert the code on copy and paste.
Also, the Apollo3 is designed for KMP, Kotlin first, 90%+ won't be using Kotlin anymore most likely.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fair, we could add a section "you can also use this in Java like this: " and the other snippets only in Kotlin. But not necesserily in ths PR