Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(replays): Update replay docs with web vital info #11336

Merged
merged 4 commits into from
Sep 12, 2024
Merged

feat(replays): Update replay docs with web vital info #11336

merged 4 commits into from
Sep 12, 2024

Conversation

c298lee
Copy link
Member

@c298lee c298lee commented Sep 11, 2024 •
edited by bruno-garcia
Loading

@vercel Vercel
Copy link

vercel bot commented Sep 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 12, 2024 4:21pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 12, 2024 4:21pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Sep 12, 2024 4:21pm

@codecov Codecov
Copy link

codecov bot commented Sep 11, 2024 •
edited
Loading

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 7.43MB 6 bytes ⬇️
sentry-docs-edge-server-array-push 257.01kB 3 bytes ⬇️
sentry-docs-client-array-push 6.4MB 6 bytes ⬇️

@c298lee c298lee requested a review from a team September 11, 2024 17:35
michellewzhang
michellewzhang approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@michellewzhang michellewzhang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait i didnt see the friyay part .....HAPPY EARLY FRIDAY

@jas-kas jas-kas requested a review from lizokm September 11, 2024 19:15
@c298lee c298lee merged commit bce90b2 into master Sep 12, 2024
10 checks passed
@c298lee c298lee deleted the cl/web-vitals-doc branch September 12, 2024 18:13
@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jas-kas jas-kas jas-kas approved these changes

@michellewzhang michellewzhang michellewzhang approved these changes

@angelajiang13 angelajiang13 Awaiting requested review from angelajiang13

@bruno-garcia bruno-garcia Awaiting requested review from bruno-garcia

@lizokm lizokm Awaiting requested review from lizokm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@c298lee @michellewzhang @jas-kas