Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(js): use client from init method in js snippets #10460

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

chargome
Copy link
Member

@chargome chargome commented Jun 21, 2024

DESCRIBE YOUR PR

Simplify code snippets for client generation in js.
#12495

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

Note: we need to wait until getsentry/sentry-javascript#12585 is released until we merge this.

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

@chargome chargome self-assigned this Jun 21, 2024
Copy link

vercel bot commented Jun 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2024 9:34am

@chargome chargome requested a review from mydea June 21, 2024 09:21
Copy link

codecov bot commented Jun 21, 2024

Bundle Report

Changes will decrease total bundle size by 7 bytes ⬇️

Bundle name Size Change
sentry-docs-server 7.55MB 2 bytes ⬇️
sentry-docs-edge-server 479.4kB 3 bytes ⬇️
sentry-docs-client 6.22MB 2 bytes ⬇️

Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can only merge this once we did a release including your change! but then, this looks great 👍

Copy link
Contributor

@vivianyentran vivianyentran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Remember to merge when the release is out :)

@chargome chargome merged commit 24e34b8 into master Jun 26, 2024
6 checks passed
@chargome chargome deleted the cg/client-return-type branch June 26, 2024 08:21
@github-actions github-actions bot locked and limited conversation to collaborators Jul 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants