Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v9]: Remove dart:html usage in favour of package:web #2710

Merged
merged 8 commits into from
Feb 13, 2025

Conversation

buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Feb 12, 2025

📜 Description

💡 Motivation and Context

Closes #2411

💚 How did you test it?

Existing tests

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.32%. Comparing base (7a0aa9a) to head (de974a7).
Report is 1 commits behind head on v9.

Additional details and impacted files
@@           Coverage Diff           @@
##               v9    #2710   +/-   ##
=======================================
  Coverage   88.32%   88.32%           
=======================================
  Files         262      262           
  Lines        8913     8913           
=======================================
  Hits         7872     7872           
  Misses       1041     1041           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@buenaflor buenaflor requested review from vaind and denrase February 12, 2025 17:24
Copy link
Collaborator

@denrase denrase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookin' good, except the conflicts.

@buenaflor buenaflor merged commit 9766800 into v9 Feb 13, 2025
149 checks passed
@buenaflor buenaflor deleted the v9-task/remove-html-usage branch February 13, 2025 15:40
@vaind vaind mentioned this pull request Feb 18, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants