Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v9]: Remove enableTracing #2695

Merged
merged 10 commits into from
Feb 13, 2025
Merged

[v9]: Remove enableTracing #2695

merged 10 commits into from
Feb 13, 2025

Conversation

buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Feb 11, 2025

📜 Description

Removes deprecated enableTracing option

💡 Motivation and Context

Part of #2411

💚 How did you test it?

Unit tests

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@buenaflor buenaflor changed the base branch from main to v9 February 11, 2025 13:19
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.29%. Comparing base (7a0aa9a) to head (4f841f1).
Report is 2 commits behind head on v9.

Additional details and impacted files
@@            Coverage Diff             @@
##               v9    #2695      +/-   ##
==========================================
- Coverage   88.32%   88.29%   -0.03%     
==========================================
  Files         262      262              
  Lines        8913     8911       -2     
==========================================
- Hits         7872     7868       -4     
- Misses       1041     1043       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@buenaflor buenaflor marked this pull request as ready for review February 12, 2025 13:37
@buenaflor buenaflor requested a review from denrase February 12, 2025 14:40
@buenaflor buenaflor merged commit d98ed02 into v9 Feb 13, 2025
153 checks passed
@buenaflor buenaflor deleted the v9-task/remove-enable-tracing branch February 13, 2025 15:47
@vaind vaind mentioned this pull request Feb 18, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants