Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v9] Remove user segment #2687

Merged
merged 4 commits into from
Feb 11, 2025
Merged

[v9] Remove user segment #2687

merged 4 commits into from
Feb 11, 2025

Conversation

buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Feb 10, 2025

📜 Description

💡 Motivation and Context

Closes #2683

Functionality is not supported anymore

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@buenaflor buenaflor changed the base branch from main to v9 February 10, 2025 23:25
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.06%. Comparing base (b2409ce) to head (9b12582).
Report is 1 commits behind head on v9.

Additional details and impacted files
@@            Coverage Diff             @@
##               v9    #2687      +/-   ##
==========================================
- Coverage   89.07%   89.06%   -0.01%     
==========================================
  Files         261      261              
  Lines        8860     8847      -13     
==========================================
- Hits         7892     7880      -12     
+ Misses        968      967       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@buenaflor buenaflor requested a review from denrase February 11, 2025 11:22
@buenaflor buenaflor merged commit e401af3 into v9 Feb 11, 2025
152 of 153 checks passed
@buenaflor buenaflor deleted the v9-task/remove-user-segment branch February 11, 2025 12:49
@vaind vaind mentioned this pull request Feb 18, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate and remove user segment
2 participants