-
-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split up Flutter's default_integrations.dart
into one file for each integration
#1037
Conversation
flutter/test/integrations/more_native_sdk_integration_test.dart
Outdated
Show resolved
Hide resolved
Codecov ReportBase: 89.98% // Head: 89.90% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1037 +/- ##
==========================================
- Coverage 89.98% 89.90% -0.09%
==========================================
Files 115 106 -9
Lines 3585 3388 -197
==========================================
- Hits 3226 3046 -180
+ Misses 359 342 -17 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
# Conflicts: # flutter/lib/src/sentry_flutter.dart
I will wait for #1039 before reviewing since it touches the same file and likely having conflicts. |
4273df5
to
5d15a51
Compare
# Conflicts: # flutter/test/load_contexts_integrations_test.dart
This is unblocked now, fixing the linter and we are good to go, thanks for doing this. |
Yeah, I also want to double check whether I messed up one of the merges, especially after the PlatformDispatcher PR |
This is now ready. Pana fails because it runs against the current published version :/ |
Thanks @ueman |
📜 Description
Split up
default_integrations.dart
into one file for each integration.This should make it easier to maintain a good overview about the integrations.
#skip-changelog
💡 Motivation and Context
There were a lot of integrations in a single file. That was hard to keep track of.
💚 How did you test it?
Current test cover this.
📝 Checklist
🔮 Next steps