Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split up Flutter's default_integrations.dart into one file for each integration #1037

Merged
merged 9 commits into from
Oct 14, 2022

Conversation

ueman
Copy link
Collaborator

@ueman ueman commented Oct 1, 2022

📜 Description

Split up default_integrations.dart into one file for each integration.
This should make it easier to maintain a good overview about the integrations.

#skip-changelog

💡 Motivation and Context

There were a lot of integrations in a single file. That was hard to keep track of.

💚 How did you test it?

Current test cover this.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2022

Codecov Report

Base: 89.98% // Head: 89.90% // Decreases project coverage by -0.08% ⚠️

Coverage data is based on head (e43c3b9) compared to base (e187bee).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1037      +/-   ##
==========================================
- Coverage   89.98%   89.90%   -0.09%     
==========================================
  Files         115      106       -9     
  Lines        3585     3388     -197     
==========================================
- Hits         3226     3046     -180     
+ Misses        359      342      -17     
Impacted Files Coverage Δ
dio/lib/src/sentry_dio_extension.dart
logging/lib/src/extension.dart
dio/lib/src/dio_event_processor.dart
dio/lib/src/breadcrumb_client_adapter.dart
dio/lib/src/tracing_client_adapter.dart
dio/lib/src/sentry_transformer.dart
dio/lib/src/sentry_dio_client_adapter.dart
dio/lib/src/failed_request_interceptor.dart
logging/lib/src/logging_integration.dart

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

# Conflicts:
#	flutter/lib/src/sentry_flutter.dart
@marandaneto
Copy link
Contributor

I will wait for #1039 before reviewing since it touches the same file and likely having conflicts.

@ueman ueman closed this Oct 12, 2022
@ueman ueman force-pushed the clean-up-integrations branch from 4273df5 to 5d15a51 Compare October 12, 2022 18:27
# Conflicts:
#	flutter/test/load_contexts_integrations_test.dart
@ueman ueman reopened this Oct 12, 2022
@marandaneto
Copy link
Contributor

@ueman

Formatted 69 files (1 changed) in 1.09 seconds.

This is unblocked now, fixing the linter and we are good to go, thanks for doing this.

@ueman
Copy link
Collaborator Author

ueman commented Oct 13, 2022

@ueman

Formatted 69 files (1 changed) in 1.09 seconds.

This is unblocked now, fixing the linter and we are good to go, thanks for doing this.

Yeah, I also want to double check whether I messed up one of the merges, especially after the PlatformDispatcher PR

@ueman
Copy link
Collaborator Author

ueman commented Oct 13, 2022

This is now ready. Pana fails because it runs against the current published version :/

@marandaneto
Copy link
Contributor

Thanks @ueman

@marandaneto marandaneto merged commit 322aa66 into getsentry:main Oct 14, 2022
@ueman ueman deleted the clean-up-integrations branch October 14, 2022 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants