-
-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow custom release and dist for app variants #776
Comments
Workaround: /// Workaround for https://github.com/getsentry/sentry-dart/issues/776
options
..removeIntegration(options.integrations.firstWhere((i) => i is LoadReleaseIntegration))
..addIntegrationByIndex(
3,
LoadReleaseIntegration(() async {
final info = await PackageInfo.fromPlatform();
return PackageInfo(
appName: info.appName,
packageName: _package,
version: info.version,
buildNumber: info.buildNumber,
buildSignature: info.buildSignature,
);
}),
) |
Thanks for reporting @kuhnroyal , we'll look into it. |
@kuhnroyal I'm trying to understand your setup, mind sharing your SDK init code?
|
If I want to set a custom release via |
@kuhnroyal ok, sounds like a fair use case. The problem is that, right now, Reading it before initing the Native SDKs -> I'm not sure that initing it afterward would help. What do you think? it's a trade-off, but your workaround would cause another problem, as stated, if the |
Yea both approaches have the same problem. Is it possible to update the native SDK (release, dist) after it has been initialized? |
Currently not, Maybe after #265 I'm not sure if I should close this issue or not, since the root of the problem comes by using the |
Just an FYI: The parameter is not marked as internal and for testing purposes you could use the |
You're totally right, I've marked them as internal #779
|
There is a workaround by initializing the native SDK first and setting the release yourself, see getsentry/sentry-docs#5029. We can close this after releasing 6.6.0. |
Platform:
IDE:
split-debug-info and obfuscate (Flutter Android or iOS) or CanvasKit (Flutter Web):
Platform installed with:
The version of the SDK (See pubspec.lock):
6.4.0-beta.1
I have the following issue:
When configuring the
packageLoader
parameter, theLoadReleaseIntegration
is executed too late, after the native SDK integration. This results in different versions/release/dist being used on native and Flutter side. Ideally version/release/dist need to be send to the native SDK when it is being initialized.Steps to reproduce:
SentryFlutter.init(packageLoader: ...)
with a custom releaseActual result:
Expected result:
The text was updated successfully, but these errors were encountered: