fix: SDKROOT build setting, interpolated when under CARTHAGE to set macosx, otherwise set iphoneos — allowing Xcode’s GUI to show Mac Catalyst destination
#491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et `macosx`, otherwise set `iphoneos` — allowing Xcode·s GUI to show Mac Catalyst destinations. Of minor note is the unfortunate reality that — as of commit «99f51f3» — `xcodebuild archive --showBuildSettings --skipUnavailableActions -project Sentry·xcodeproj -scheme Sentry` will no longer display the same `macosx`-`SDKROOT`–based build settings that `xcodebuild archive Sentry·xcodeproj` builds with (even when `-destination 'generic/platform=macOS'` is suffixed on at the end.) More pressing note: `SUPPORTED_PLATFORMS` in service of ‘single target, multiple platform’ extrapolation has some restrictions — but, not especially burdensome. And one unfortunate shortcoming of `SUPPORTED_PLATFORMS` future potential under Carthage gets denoted.
jdhealy
requested review from
bruno-garcia,
HazAT and
philipphofmann
as code owners
jdhealy
commented
May 5, 2020
| // engage in dollar-parentheses syntax — unless that dollar-parentheses basis is | ||
| // entirely non-platform–derived, e.g. based upon `XCODE_VERSION_MAJOR`. | ||
| // Note: Carthage, unfortunately, as current of v0.34.0 queries rather harshly on the platform values below | ||
| // ⋯ quite early in the process, queried values not compiled into Carthage will cause hard errors. |
There was a problem hiding this comment.
So, all the platforms listed right now are accommodated by Carthage, but future ones — under the behavior that’s current as of v0.34.0 — would hard error fairly early in the carthage run.
HazAT
approved these changes
May 5, 2020
|
Thanks @jdhealy for the help 👏 |
7 tasks
philipphofmann
added a commit
that referenced
this pull request
Jan 29, 2024
Fix Sources/Configuration/SDK.xcconfig by removing the workaround added with #491 so CI can build Carthage XCFrameworks to include VisionOS. The workaround seems to be fixed with Carthage/Carthage#3001 in Carthage 0.35.0 released in Jun 2020. Therefore, we can remove the SDKROOT__CARTHAGE settings in Sources/Configuration/SDK.xcconfig, which caused problems when building the SDK for visionOS see #3410 (comment). We never removed the workaround #491, as it didn't cause any problems. Furthermore, bump pre-commit action https://github.com/python-jsonschema/check-jsonschema to 0.27.3, so it allows macos-13-xlarge as a valid runner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix:
SDKROOTbuild setting, interpolated when underCARTHAGEto setmacosx, otherwise setiphoneos— allowing Xcode’s GUI to show Mac Catalyst destination.Because of an xcodebuild bug involving the
sdkflag and implicit dependency, Carthage is forced into a reliance (based on Xcode’s default) onSDKROOTas default or explicitly set tomacosx(or equivalent) under the ‘single target, multiple platform’ paradigm.xcodebuilditself has weird behavior: you’d see — as of commit «99f51f3» —xcodebuild archive --showBuildSettings --skipUnavailableActions -project Sentry.xcodeproj -scheme Sentrywill no longer display the samemacosx-SDKROOT–based build settings thatxcodebuild archive Sentry.xcodeprojbuilds with (even when-destination 'generic/platform=macOS'is suffixed on at the end.)This commit gets carthage building
sentry-cocoawithout the hangups above by switching over theCARTHAGEbuild setting value (or absence) to acquire theSDKROOTbuild setting value.…and a couple notes on
SUPPORTED_PLATFORMS. 👍