Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add type-safety for screenshots result array #4843

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

philprime
Copy link
Contributor

The screenshots array had wrong typing causing crashes due to type casting

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.171%. Comparing base (d3a65fb) to head (18baca0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...Integrations/Screenshot/TestSentryScreenShot.swift 33.333% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             main     #4843        +/-   ##
=============================================
+ Coverage   9.108%   92.171%   +83.063%     
=============================================
  Files         350       658       +308     
  Lines       24934     77222     +52288     
  Branches       94     27170     +27076     
=============================================
+ Hits         2271     71177     +68906     
+ Misses      22663      5953     -16710     
- Partials        0        92        +92     
Files with missing lines Coverage Δ
Sources/Sentry/SentryScreenshot.m 81.666% <100.000%> (+81.666%) ⬆️
Sources/Sentry/SentryScreenshotIntegration.m 92.156% <100.000%> (+92.156%) ⬆️
Tests/SentryTests/SentryScreenShotTests.swift 100.000% <100.000%> (ø)
...Integrations/Screenshot/TestSentryScreenShot.swift 66.666% <33.333%> (ø)

... and 646 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3a65fb...18baca0. Read the comment docs.

Copy link

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1217.61 ms 1243.51 ms 25.90 ms
Size 22.31 KiB 819.56 KiB 797.24 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
742d4b6 1196.56 ms 1216.54 ms 19.98 ms
50b058e 1212.29 ms 1231.16 ms 18.88 ms
4053ee9 1248.04 ms 1250.82 ms 2.78 ms
80f2f39 1241.88 ms 1267.06 ms 25.18 ms
5e579af 1239.40 ms 1257.29 ms 17.89 ms
3e7aa41 1214.02 ms 1238.84 ms 24.82 ms
4d3df92 1218.27 ms 1248.30 ms 30.03 ms
29567a9 1231.60 ms 1251.59 ms 19.99 ms
725565a 1234.59 ms 1250.02 ms 15.43 ms
a9103fe 1265.47 ms 1267.37 ms 1.90 ms

App size

Revision Plain With Sentry Diff
742d4b6 21.58 KiB 546.20 KiB 524.62 KiB
50b058e 21.58 KiB 714.30 KiB 692.72 KiB
4053ee9 20.76 KiB 435.22 KiB 414.46 KiB
80f2f39 21.58 KiB 704.93 KiB 683.35 KiB
5e579af 21.58 KiB 656.60 KiB 635.02 KiB
3e7aa41 20.76 KiB 432.31 KiB 411.55 KiB
4d3df92 22.85 KiB 413.45 KiB 390.60 KiB
29567a9 21.58 KiB 713.97 KiB 692.39 KiB
725565a 20.76 KiB 426.11 KiB 405.35 KiB
a9103fe 20.76 KiB 426.95 KiB 406.19 KiB

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philipphofmann philipphofmann merged commit 3eb74c2 into main Feb 13, 2025
71 of 72 checks passed
@philipphofmann philipphofmann deleted the philprime/fix-sentry-screenshot-typing branch February 13, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants