Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impr: More info when hub can't start session #4752

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

philipphofmann
Copy link
Member

📜 Description

Improve the log message in the hub when it can't start a session when the client doesn't have any options or the options don't have a release name.

💡 Motivation and Context

The log message No option or release to start a session. came up in a Zendesk issue. It would be great to know if the options or the release are nil.

💚 How did you test it?

Unit tests.

📝 Checklist

You have to check all boxes before merging:

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Improve the log message in the hub when it can't start a session when
the client doesn't have any options or the options don't have a release
name.
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.113%. Comparing base (ba3679b) to head (c9c318e).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4752       +/-   ##
=============================================
- Coverage   91.194%   91.113%   -0.081%     
=============================================
  Files          623       623               
  Lines        72498     72506        +8     
  Branches     26411     25784      -627     
=============================================
- Hits         66114     66063       -51     
- Misses        6285      6348       +63     
+ Partials        99        95        -4     
Files with missing lines Coverage Δ
Sources/Sentry/SentryHub.m 97.977% <100.000%> (+0.011%) ⬆️
Tests/SentryTests/SentryHubTests.swift 98.884% <100.000%> (+0.012%) ⬆️

... and 23 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba3679b...c9c318e. Read the comment docs.

Copy link

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1238.11 ms 1251.53 ms 13.42 ms
Size 22.31 KiB 775.13 KiB 752.81 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
c151c14 1223.18 ms 1246.56 ms 23.38 ms
9324d27 1242.25 ms 1255.15 ms 12.90 ms
a176fc4 1250.29 ms 1257.88 ms 7.59 ms
e19cca3 1211.69 ms 1231.04 ms 19.35 ms
c586015 1221.20 ms 1236.80 ms 15.59 ms
279841c 1237.29 ms 1254.12 ms 16.83 ms
1a4da1b 1222.14 ms 1239.50 ms 17.36 ms
9f57953 1232.83 ms 1249.87 ms 17.04 ms
e71cf92 1201.69 ms 1226.52 ms 24.83 ms
5c6ef23 1237.33 ms 1252.58 ms 15.25 ms

App size

Revision Plain With Sentry Diff
c151c14 21.58 KiB 678.19 KiB 656.61 KiB
9324d27 21.58 KiB 707.43 KiB 685.85 KiB
a176fc4 22.84 KiB 403.24 KiB 380.39 KiB
e19cca3 21.58 KiB 669.74 KiB 648.16 KiB
c586015 21.58 KiB 616.73 KiB 595.15 KiB
279841c 22.84 KiB 403.19 KiB 380.34 KiB
1a4da1b 21.58 KiB 418.33 KiB 396.75 KiB
9f57953 22.31 KiB 773.84 KiB 751.53 KiB
e71cf92 20.76 KiB 419.85 KiB 399.10 KiB
5c6ef23 21.90 KiB 708.96 KiB 687.05 KiB

@philipphofmann philipphofmann merged commit f53e48a into main Jan 27, 2025
65 of 71 checks passed
@philipphofmann philipphofmann deleted the impr/hub-sessio-start-logs branch January 27, 2025 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants