Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Session replay masking preview for SwiftUI #4737
feat: Session replay masking preview for SwiftUI #4737
Changes from all commits
3104d20
43301b6
c12d5e2
7c8ccbf
5ade0b1
cd845bf
410f8f6
00ab82c
2eb7e4c
82acf29
276f608
db55f9d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 328 in Sources/Sentry/PrivateSentrySDKOnly.mm
Sources/Sentry/PrivateSentrySDKOnly.mm#L327-L328
Check warning on line 644 in Sources/Sentry/SentrySessionReplayIntegration.m
Sources/Sentry/SentrySessionReplayIntegration.m#L643-L644
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since
SentryMaskingPreviewView
is an internal Swift class from Sentry, we cant use from SentrySwiftUI. In order to solve this, we just use PrivateSentrySDKOnly to return it as a UIView.