Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Make SentryId Sendable #4553

Merged
merged 2 commits into from
Nov 21, 2024
Merged

ref: Make SentryId Sendable #4553

merged 2 commits into from
Nov 21, 2024

Conversation

brustolin
Copy link
Contributor

📜 Description

Transform SentryId into a Sendable to easily accommodate for strict concurrency

💡 Motivation and Context

close #4545

📝 Checklist

You have to check all boxes before merging:

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.604%. Comparing base (da7a50e) to head (4104967).
Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #4553   +/-   ##
=========================================
  Coverage   91.604%   91.604%           
=========================================
  Files          615       615           
  Lines        69928     69920    -8     
  Branches     25068     25044   -24     
=========================================
- Hits         64057     64050    -7     
+ Misses        5778      5776    -2     
- Partials        93        94    +1     
Files with missing lines Coverage Δ
Sources/Swift/Protocol/SentryId.swift 97.560% <ø> (ø)

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da7a50e...4104967. Read the comment docs.

---- 🚨 Try these New Features:

Copy link

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1220.84 ms 1243.45 ms 22.61 ms
Size 22.30 KiB 730.69 KiB 708.39 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
a95ba2f 1223.52 ms 1245.69 ms 22.17 ms
53a8885 1241.02 ms 1270.66 ms 29.64 ms
06bac56 1213.62 ms 1236.27 ms 22.65 ms
c4e9093 1219.04 ms 1236.00 ms 16.96 ms
d3630c3 1248.52 ms 1262.70 ms 14.18 ms
2af280d 1246.22 ms 1253.10 ms 6.88 ms
e072ad1 1232.43 ms 1245.51 ms 13.08 ms
ecd9ecd 1214.16 ms 1232.59 ms 18.43 ms
8c4ac55 1231.02 ms 1253.17 ms 22.15 ms
1db04d8 1250.20 ms 1258.12 ms 7.92 ms

App size

Revision Plain With Sentry Diff
a95ba2f 21.58 KiB 706.46 KiB 684.88 KiB
53a8885 20.76 KiB 434.65 KiB 413.89 KiB
06bac56 22.84 KiB 403.23 KiB 380.39 KiB
c4e9093 21.58 KiB 671.30 KiB 649.72 KiB
d3630c3 22.84 KiB 403.19 KiB 380.34 KiB
2af280d 20.76 KiB 435.22 KiB 414.46 KiB
e072ad1 21.58 KiB 625.83 KiB 604.24 KiB
ecd9ecd 20.76 KiB 420.23 KiB 399.47 KiB
8c4ac55 21.58 KiB 706.21 KiB 684.63 KiB
1db04d8 20.76 KiB 435.50 KiB 414.74 KiB

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brustolin brustolin merged commit 4d22351 into main Nov 21, 2024
64 of 65 checks passed
@brustolin brustolin deleted the ref/sendable-sentryID branch November 21, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conform SentryId to Sendable
2 participants