Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Concurrency crash for Swift 6 #4512

Merged
merged 34 commits into from
Nov 11, 2024
Merged

fix: Concurrency crash for Swift 6 #4512

merged 34 commits into from
Nov 11, 2024

Conversation

brustolin
Copy link
Contributor

📜 Description

Swift 6 introduce some concurrency checks to avoid race conditions, but objc does not have this features.
We need to annotate of callbacks so swift knows how it will be used.

💡 Motivation and Context

Close #4509

💚 How did you test it?

Samples and UITest

📝 Checklist

You have to check all boxes before merging:

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link

github-actions bot commented Nov 7, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1234.47 ms 1252.08 ms 17.61 ms
Size 22.30 KiB 730.10 KiB 707.80 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
6bc5ae5 1207.23 ms 1216.66 ms 9.43 ms
65e48e0 1223.68 ms 1238.96 ms 15.28 ms
5616e0a 1224.12 ms 1249.86 ms 25.74 ms
6943de0 1230.02 ms 1235.32 ms 5.30 ms
3db3e35 1233.52 ms 1256.43 ms 22.90 ms
aea5987 1223.84 ms 1244.39 ms 20.55 ms
ed49f0c 1245.67 ms 1261.15 ms 15.48 ms
20a828b 1211.33 ms 1228.00 ms 16.67 ms
af1f4dd 1225.39 ms 1245.48 ms 20.09 ms
50bb751 1234.10 ms 1248.29 ms 14.19 ms

App size

Revision Plain With Sentry Diff
6bc5ae5 20.76 KiB 401.39 KiB 380.63 KiB
65e48e0 21.90 KiB 708.34 KiB 686.44 KiB
5616e0a 22.85 KiB 407.44 KiB 384.59 KiB
6943de0 20.76 KiB 393.33 KiB 372.57 KiB
3db3e35 21.58 KiB 419.21 KiB 397.63 KiB
aea5987 21.58 KiB 418.13 KiB 396.54 KiB
ed49f0c 21.58 KiB 632.13 KiB 610.55 KiB
20a828b 21.58 KiB 670.99 KiB 649.41 KiB
af1f4dd 22.85 KiB 414.71 KiB 391.86 KiB
50bb751 21.58 KiB 417.86 KiB 396.27 KiB

Previous results on branch: fix/sendabla-callback

Startup times

Revision Plain With Sentry Diff
371a05e 1239.55 ms 1261.59 ms 22.04 ms

App size

Revision Plain With Sentry Diff
371a05e 21.90 KiB 726.89 KiB 704.99 KiB

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.519%. Comparing base (05ac767) to head (4529c3e).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4512       +/-   ##
=============================================
+ Coverage   91.465%   91.519%   +0.053%     
=============================================
  Files          615       615               
  Lines        68992     69473      +481     
  Branches     24753     24923      +170     
=============================================
+ Hits         63104     63581      +477     
- Misses        5795      5800        +5     
+ Partials        93        92        -1     

see 39 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05ac767...4529c3e. Read the comment docs.

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. I'm only waiting for CI to be green. Thanks for adding a sample

@brustolin
Copy link
Contributor Author

This looks great. I'm only waiting for CI to be green. Thanks for adding a sample

Ci is drunk today.

@brustolin brustolin marked this pull request as ready for review November 11, 2024 08:14
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding a sample. Maybe it makes sense to use SwiftUI; see comment. LGTM.

@brustolin brustolin merged commit 4509e9c into main Nov 11, 2024
66 checks passed
@brustolin brustolin deleted the fix/sendabla-callback branch November 11, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash caused by inclusion of beforeSend option.
3 participants