-
-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Concurrency crash for Swift 6 #4512
Conversation
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
6bc5ae5 | 1207.23 ms | 1216.66 ms | 9.43 ms |
65e48e0 | 1223.68 ms | 1238.96 ms | 15.28 ms |
5616e0a | 1224.12 ms | 1249.86 ms | 25.74 ms |
6943de0 | 1230.02 ms | 1235.32 ms | 5.30 ms |
3db3e35 | 1233.52 ms | 1256.43 ms | 22.90 ms |
aea5987 | 1223.84 ms | 1244.39 ms | 20.55 ms |
ed49f0c | 1245.67 ms | 1261.15 ms | 15.48 ms |
20a828b | 1211.33 ms | 1228.00 ms | 16.67 ms |
af1f4dd | 1225.39 ms | 1245.48 ms | 20.09 ms |
50bb751 | 1234.10 ms | 1248.29 ms | 14.19 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
6bc5ae5 | 20.76 KiB | 401.39 KiB | 380.63 KiB |
65e48e0 | 21.90 KiB | 708.34 KiB | 686.44 KiB |
5616e0a | 22.85 KiB | 407.44 KiB | 384.59 KiB |
6943de0 | 20.76 KiB | 393.33 KiB | 372.57 KiB |
3db3e35 | 21.58 KiB | 419.21 KiB | 397.63 KiB |
aea5987 | 21.58 KiB | 418.13 KiB | 396.54 KiB |
ed49f0c | 21.58 KiB | 632.13 KiB | 610.55 KiB |
20a828b | 21.58 KiB | 670.99 KiB | 649.41 KiB |
af1f4dd | 22.85 KiB | 414.71 KiB | 391.86 KiB |
50bb751 | 21.58 KiB | 417.86 KiB | 396.27 KiB |
…sentry-cocoa into fix/sendabla-callback
…sentry-cocoa into fix/sendabla-callback
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4512 +/- ##
=============================================
+ Coverage 91.465% 91.519% +0.053%
=============================================
Files 615 615
Lines 68992 69473 +481
Branches 24753 24923 +170
=============================================
+ Hits 63104 63581 +477
- Misses 5795 5800 +5
+ Partials 93 92 -1 see 39 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. I'm only waiting for CI to be green. Thanks for adding a sample
Ci is drunk today. |
…sentry-cocoa into fix/sendabla-callback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding a sample. Maybe it makes sense to use SwiftUI; see comment. LGTM.
📜 Description
Swift 6 introduce some concurrency checks to avoid race conditions, but objc does not have this features.
We need to annotate of callbacks so swift knows how it will be used.
💡 Motivation and Context
Close #4509
💚 How did you test it?
Samples and UITest
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.🔮 Next steps