Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Option for uncaught NSExceptions on macOS #4471

Merged
merged 7 commits into from
Oct 29, 2024

fix ci

42572ec
Select commit
Loading
Failed to load commit list.
Merged

feat: Option for uncaught NSExceptions on macOS #4471

fix ci
42572ec
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Oct 29, 2024 in 0s

91.797% (-0.011%) compared to 27bdedd

View this Pull Request on Codecov

91.797% (-0.011%) compared to 27bdedd

Details

Codecov Report

Attention: Patch coverage is 17.64706% with 14 lines in your changes missing coverage. Please review.

Project coverage is 91.797%. Comparing base (27bdedd) to head (42572ec).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
SentryTestUtils/ClearTestState.swift 0.000% 9 Missing ⚠️
.../SentryCrash/SentryUncaughtNSExceptionsTests.swift 0.000% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4471       +/-   ##
=============================================
- Coverage   91.807%   91.797%   -0.011%     
=============================================
  Files          610       611        +1     
  Lines        68235     68247       +12     
  Branches     24502     24496        -6     
=============================================
+ Hits         62645     62649        +4     
- Misses        5498      5505        +7     
- Partials        92        93        +1     
Files with missing lines Coverage Δ
Sources/Sentry/SentryCrashIntegration.m 99.047% <100.000%> (+0.018%) ⬆️
Sources/Sentry/SentryOptions.m 99.433% <ø> (ø)
...ions/SentryCrash/SentryCrashIntegrationTests.swift 86.850% <ø> (ø)
Tests/SentryTests/SentryOptionsTest.m 98.451% <ø> (ø)
.../SentryCrash/SentryUncaughtNSExceptionsTests.swift 0.000% <0.000%> (ø)
SentryTestUtils/ClearTestState.swift 85.714% <0.000%> (-14.286%) ⬇️

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27bdedd...42572ec. Read the comment docs.