-
-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mergeable libraries support to dynamic libraries #4381
Conversation
|
Created a new PR which only enables mergeable libraries for the xcframeworks we build for SPM usage. (See #4367 for more info) Reasons:
So we'd need to bump all CI to at least macos-14 and Xcode 15.2. Building with fastlane only worked with macos-14 and Xcode 16.
Conditionals are not supported, and we cannot create xcconfig files based on platform. So this is the least invasive way to add support for mergeable libraries. Still there's the large caviat that users need to use Xcode >= 15, so we need to consider this before merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @denrase, LGTM
📜 Description
make_mergable
linker flags to supported SDKsFrom the
ld
manual:Also, users have to build with Xcode >= 15.
💡 Motivation and Context
Users can enable mergable libraries featue for dynamic sentry frameworks.
See https://developer.apple.com/documentation/xcode/configuring-your-project-to-use-mergeable-libraries for more info.
💚 How did you test it?
Closes #3719
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.