-
-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Don't redact clipped views #4325
fix: Don't redact clipped views #4325
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## fix/redact-under-translucent #4325 +/- ##
==============================================================
Coverage 91.669% 91.670%
==============================================================
Files 618 618
Lines 50286 50325 +39
Branches 18123 18135 +12
==============================================================
+ Hits 46097 46133 +36
- Misses 4097 4099 +2
- Partials 92 93 +1
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
a268d0b | 1223.94 ms | 1242.94 ms | 19.00 ms |
70ebda6 | 1238.09 ms | 1247.11 ms | 9.03 ms |
b2f8339 | 1218.12 ms | 1243.32 ms | 25.20 ms |
be34bdf | 1228.30 ms | 1244.78 ms | 16.48 ms |
11b37b6 | 1239.22 ms | 1259.82 ms | 20.59 ms |
bf4bb59 | 1231.86 ms | 1251.20 ms | 19.35 ms |
fda51b1 | 1229.89 ms | 1237.02 ms | 7.13 ms |
1e7fd29 | 1242.35 ms | 1260.59 ms | 18.24 ms |
8ee29d0 | 1227.21 ms | 1242.84 ms | 15.63 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
a268d0b | 21.58 KiB | 707.29 KiB | 685.70 KiB |
70ebda6 | 21.58 KiB | 707.13 KiB | 685.55 KiB |
b2f8339 | 21.58 KiB | 707.34 KiB | 685.76 KiB |
be34bdf | 21.58 KiB | 707.33 KiB | 685.75 KiB |
11b37b6 | 21.58 KiB | 707.84 KiB | 686.26 KiB |
bf4bb59 | 21.58 KiB | 707.34 KiB | 685.76 KiB |
fda51b1 | 21.58 KiB | 707.34 KiB | 685.76 KiB |
1e7fd29 | 21.58 KiB | 707.14 KiB | 685.56 KiB |
8ee29d0 | 21.58 KiB | 707.40 KiB | 685.82 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the extra explanation in the comments 🙏🏻 Seems fine
cf60b5e
into
fix/redact-under-translucent
📜 Description
A label that is outside of bounds of a view with clipBounds true is no longer being redacted.
💚 How did you test it?
Unit tests
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.🔮 Next steps