Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST: Mergeable Sample #4301

Closed
wants to merge 2 commits into from
Closed

TEST: Mergeable Sample #4301

wants to merge 2 commits into from

Conversation

denrase
Copy link
Collaborator

@denrase denrase commented Aug 26, 2024

📜 Description

I have added the mergeable flags to our build script and tested release builds in the Simulator on macOS.

The sample project is embedding the Sentry dynamic library.

Size

The archive is slightly smaller with mergeable enabled, but the installed app should be slightly larger because of additional metadata.

Default Mergeable
Bildschirmfoto 2024-08-26 um 16 06 41 Bildschirmfoto 2024-08-26 um 16 06 35

Launch Time

Load times are similar. Launched both versions 10 times after the initial installation. Launching from Xcode takes longer when using mergeable instead of the default dylib.

Default Mergeable
app_launch_time_2_dyn app_launch_time_2_merged

Conclusion

We could add the linker flags to our build script for Sentry-Dynamic. Users can then decide if they want to use mergeable. This is opt-in for them, as the default is the same as before.

We can delete this PR afterwards.

💡 Motivation and Context

Sample to test mergeable option.

Relates to #3719

@kahest
Copy link
Member

kahest commented Sep 3, 2024

The archive is slightly smaller with mergeable enabled, but the installed app should be slightly larger because of additional metadata.

Not sure I fully understand this - I see a difference of 1.6 MB vs. 116 KB, which is significant, but you're saying in a real-world installed app on a device it would be more than 116 KB?

@denrase
Copy link
Collaborator Author

denrase commented Sep 5, 2024

@kahest The non-mergable has the frameworks folder, where the sentry framework is included (the folder size is not shown in the screenshot). The mergable has the sentry framework plus some metadata, so it should be slightly larger, at least thats how i understood the documentation

@brustolin
Copy link
Contributor

brustolin commented Sep 5, 2024

We can delete this PR afterwards

Can we make the changes to enable Mergeable Samples instead?
If it is easier to just create a new PR that's ok.

@denrase
Copy link
Collaborator Author

denrase commented Sep 24, 2024

Closing in favor of #4367

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants