-
-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add options to redact or ignore view for Replay #4228
Conversation
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
2af280d | 1232.31 ms | 1249.98 ms | 17.67 ms |
2df93b0 | 1210.73 ms | 1228.76 ms | 18.02 ms |
ff5c1d8 | 1244.30 ms | 1263.96 ms | 19.66 ms |
32e64d1 | 1224.45 ms | 1238.94 ms | 14.49 ms |
ea2a263 | 1201.84 ms | 1214.78 ms | 12.94 ms |
6001822 | 1220.82 ms | 1245.02 ms | 24.20 ms |
aad68bb | 1221.12 ms | 1237.41 ms | 16.29 ms |
be51b56 | 1220.84 ms | 1249.36 ms | 28.52 ms |
2405ba5 | 1248.37 ms | 1259.30 ms | 10.93 ms |
f1c36e0 | 1215.18 ms | 1223.62 ms | 8.43 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
2af280d | 20.76 KiB | 435.22 KiB | 414.46 KiB |
2df93b0 | 21.58 KiB | 682.40 KiB | 660.81 KiB |
ff5c1d8 | 20.76 KiB | 430.98 KiB | 410.22 KiB |
32e64d1 | 20.76 KiB | 433.18 KiB | 412.42 KiB |
ea2a263 | 21.58 KiB | 418.58 KiB | 396.99 KiB |
6001822 | 22.85 KiB | 410.98 KiB | 388.13 KiB |
aad68bb | 21.58 KiB | 542.38 KiB | 520.80 KiB |
be51b56 | 20.76 KiB | 432.20 KiB | 411.44 KiB |
2405ba5 | 20.76 KiB | 435.23 KiB | 414.47 KiB |
f1c36e0 | 21.58 KiB | 670.40 KiB | 648.81 KiB |
Previous results on branch: feat/custom-redact
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
8080f83 | 1234.22 ms | 1253.59 ms | 19.37 ms |
e35cf54 | 1224.96 ms | 1236.94 ms | 11.98 ms |
f29c46f | 1241.43 ms | 1243.91 ms | 2.49 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
8080f83 | 21.58 KiB | 697.44 KiB | 675.86 KiB |
e35cf54 | 21.58 KiB | 697.68 KiB | 676.10 KiB |
f29c46f | 21.58 KiB | 697.45 KiB | 675.87 KiB |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4228 +/- ##
=============================================
+ Coverage 91.350% 91.485% +0.134%
=============================================
Files 610 612 +2
Lines 48963 49340 +377
Branches 17596 17837 +241
=============================================
+ Hits 44728 45139 +411
+ Misses 4142 4109 -33
+ Partials 93 92 -1
... and 49 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with a couple of comments. Nothing blocking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, LGTM.
📜 Description
Added options to ReplayOptions for users to specify which classes to redact or ignore during replay.
Also added functions to SentrySDK and a UIView extension to choose specific views to redact or ignore.
💚 How did you test it?
Unit tests
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.