Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add a launch flag to allow skipping the sentry initialization #4189

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

armcknight
Copy link
Member

helped to try reproducing a certain customer use case

#skip-changelog

helped to try reproducing a certain customer use case
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.415%. Comparing base (2a769ba) to head (4e24cd9).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4189       +/-   ##
=============================================
+ Coverage   91.411%   91.415%   +0.003%     
=============================================
  Files          606       606               
  Lines        48659     48658        -1     
  Branches     17555     17558        +3     
=============================================
+ Hits         44480     44481        +1     
+ Misses        4086      4085        -1     
+ Partials        93        92        -1     

see 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a769ba...4e24cd9. Read the comment docs.

Copy link

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1228.23 ms 1249.17 ms 20.94 ms
Size 21.58 KiB 683.63 KiB 662.05 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
699d76f 1221.63 ms 1249.92 ms 28.28 ms
23e2db5 1240.96 ms 1253.86 ms 12.90 ms
69d8759 1235.71 ms 1241.34 ms 5.63 ms
7419285 1209.53 ms 1244.72 ms 35.19 ms
c021422 1237.12 ms 1263.18 ms 26.06 ms
4654f66 1247.16 ms 1263.96 ms 16.80 ms
dfde86d 1215.12 ms 1221.30 ms 6.18 ms
e84bc3f 1257.08 ms 1267.41 ms 10.33 ms
eaf3840 1264.94 ms 1274.04 ms 9.10 ms
794f87f 1225.78 ms 1243.46 ms 17.68 ms

App size

Revision Plain With Sentry Diff
699d76f 21.58 KiB 631.83 KiB 610.25 KiB
23e2db5 20.76 KiB 434.97 KiB 414.21 KiB
69d8759 20.76 KiB 393.05 KiB 372.29 KiB
7419285 20.76 KiB 432.99 KiB 412.22 KiB
c021422 20.76 KiB 435.64 KiB 414.88 KiB
4654f66 20.76 KiB 432.17 KiB 411.41 KiB
dfde86d 21.58 KiB 414.57 KiB 392.99 KiB
e84bc3f 20.76 KiB 434.72 KiB 413.96 KiB
eaf3840 22.84 KiB 401.67 KiB 378.83 KiB
794f87f 20.76 KiB 401.37 KiB 380.61 KiB

@armcknight armcknight merged commit 84fdd22 into main Jul 24, 2024
66 of 67 checks passed
@armcknight armcknight deleted the armcknight/test/add-init-option branch July 24, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants