Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Disable logs for a failing metrics test #3967

Merged
merged 1 commit into from
May 10, 2024

Conversation

philipphofmann
Copy link
Member

The test timed out in CI. Let's disable logs to speed it up.

#skip-changedlog

The test timed out in CI. Let's disable logs to speed it up.
Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.868%. Comparing base (379ff2a) to head (c569eb6).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #3967   +/-   ##
=========================================
  Coverage   90.868%   90.868%           
=========================================
  Files          594       594           
  Lines        46061     46061           
  Branches     16432     16443   +11     
=========================================
  Hits         41855     41855           
  Misses        4136      4136           
  Partials        70        70           
Files Coverage Δ
...s/Swift/Metrics/BucketMetricsAggregatorTests.swift 100.000% <100.000%> (ø)

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 379ff2a...c569eb6. Read the comment docs.

@philipphofmann philipphofmann merged commit e072ad1 into main May 10, 2024
51 of 52 checks passed
@philipphofmann philipphofmann deleted the test/disable-logs-for-failing-metric-test branch May 10, 2024 12:27
threema-matteo pushed a commit to threema-ch/sentry-cocoa that referenced this pull request May 21, 2024
The test timed out in CI. Let's disable logs to speed it up.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants