-
-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(profiling): prefix some functions with "sentry_" #3862
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe prefixing is good enough, thanks for solve this one. The changes looks good to me but CI is not happy.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## armcknight/test/fix-crash-recovery-test #3862 +/- ##
=============================================================================
+ Coverage 90.536% 90.584% +0.047%
=============================================================================
Files 578 579 +1
Lines 45206 45296 +90
Branches 16070 16114 +44
=============================================================================
+ Hits 40928 41031 +103
- Misses 4098 4195 +97
+ Partials 180 70 -110
... and 35 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
adb906d
to
c111d44
Compare
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
afce5bf | 1199.94 ms | 1213.27 ms | 13.33 ms |
4b08ceb | 1237.75 ms | 1249.61 ms | 11.86 ms |
addcf42 | 1247.33 ms | 1253.58 ms | 6.25 ms |
3297d6e | 1206.80 ms | 1213.86 ms | 7.06 ms |
d60f70a | 1219.63 ms | 1228.54 ms | 8.91 ms |
9f0d9e0 | 1206.55 ms | 1219.41 ms | 12.86 ms |
d8eb419 | 1221.91 ms | 1253.62 ms | 31.71 ms |
340fb46 | 1224.60 ms | 1239.27 ms | 14.67 ms |
1d11695 | 1219.57 ms | 1243.52 ms | 23.95 ms |
e0f077c | 1224.65 ms | 1243.52 ms | 18.87 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
afce5bf | 21.58 KiB | 542.18 KiB | 520.60 KiB |
4b08ceb | 20.76 KiB | 431.99 KiB | 411.23 KiB |
addcf42 | 22.85 KiB | 413.42 KiB | 390.57 KiB |
3297d6e | 21.58 KiB | 418.44 KiB | 396.86 KiB |
d60f70a | 20.76 KiB | 430.97 KiB | 410.21 KiB |
9f0d9e0 | 21.58 KiB | 424.28 KiB | 402.70 KiB |
d8eb419 | 22.85 KiB | 408.87 KiB | 386.02 KiB |
340fb46 | 21.58 KiB | 418.78 KiB | 397.20 KiB |
1d11695 | 20.76 KiB | 401.60 KiB | 380.84 KiB |
e0f077c | 22.85 KiB | 412.59 KiB | 389.74 KiB |
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- prefix some functions with "sentry_" ([#3862](https://github.com/getsentry/sentry-cocoa/pull/3862)) If none of the above apply, you can opt out of this check by adding |
We should've been prefixing any functions in the global namespace to avoid potential collisions with other apps' functions. Fixes the immediate problem reported in #3856, but we may need to do more here with all other functions. These generic functions names present the most likely possibility for collisions, though, so this should practically fix most of the issue.
Closes #3856