test: Improve SentryReachabilityTests

[philipphofmann]

The SentryReachabilityTests are still sometimes failing in CI. We now skip registering and unregistering the actual callbacks to SCNetworkReachability for all tests except one to minimize side effects.

#skip-changelog

[codecov]

Codecov Report

Merging #3399 (7802da2) into main (af1f4dd) will decrease coverage by 0.020%.
Report is 5 commits behind head on main.
The diff coverage is 100.000%.

Additional details and impacted files

@@              Coverage Diff              @@
##              main     #3399       +/-   ##
=============================================
- Coverage   88.956%   88.937%   -0.020%     
=============================================
  Files          521       521               
  Lines        56088     56162       +74     
  Branches     19950     19982       +32     
=============================================
+ Hits         49894     49949       +55     
- Misses        5278      5286        +8     
- Partials       916       927       +11     

Files	Coverage Δ
Sources/Sentry/SentryReachability.m	98.529% <100.000%> (+0.253%)	⬆️
...s/SentryTests/Networking/SentryReachabilityTests.m	71.875% <100.000%> (+2.212%)	⬆️

... and 17 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af1f4dd...7802da2. Read the comment docs.

[github-actions]

Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1216.38 ms	1225.80 ms	9.42 ms
Size	22.85 KiB	414.65 KiB	391.80 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
a6c634b	1235.86 ms	1250.53 ms	14.67 ms
e84bc3f	1201.49 ms	1232.82 ms	31.33 ms
e324230	1254.92 ms	1262.92 ms	8.00 ms
01a28a9	1237.24 ms	1253.24 ms	16.00 ms
e7b566f	1197.49 ms	1229.46 ms	31.97 ms
a54df45	1232.62 ms	1247.30 ms	14.68 ms
8c50edb	1212.98 ms	1233.72 ms	20.74 ms
189b629	1250.64 ms	1261.02 ms	10.38 ms
97797b4	1199.27 ms	1213.54 ms	14.27 ms
f938d24	1223.26 ms	1242.12 ms	18.86 ms

App size

Revision	Plain	With Sentry	Diff
a6c634b	20.76 KiB	393.37 KiB	372.61 KiB
e84bc3f	20.76 KiB	434.72 KiB	413.96 KiB
e324230	22.85 KiB	408.88 KiB	386.03 KiB
01a28a9	22.85 KiB	405.39 KiB	382.54 KiB
e7b566f	22.85 KiB	414.80 KiB	391.95 KiB
a54df45	20.76 KiB	434.88 KiB	414.12 KiB
8c50edb	20.76 KiB	432.31 KiB	411.55 KiB
189b629	20.76 KiB	399.69 KiB	378.93 KiB
97797b4	22.85 KiB	408.72 KiB	385.87 KiB
f938d24	20.76 KiB	434.88 KiB	414.12 KiB

Previous results on branch: test/reachability-tests

Startup times

Revision	Plain	With Sentry	Diff
4af7b0d	1201.12 ms	1222.54 ms	21.42 ms
f144d27	1232.94 ms	1254.58 ms	21.64 ms
5d44333	1214.45 ms	1246.26 ms	31.81 ms
d6116d1	1233.66 ms	1256.84 ms	23.18 ms
f1eae65	1257.22 ms	1262.44 ms	5.22 ms

App size

Revision	Plain	With Sentry	Diff
4af7b0d	22.85 KiB	411.10 KiB	388.25 KiB
f144d27	22.85 KiB	415.21 KiB	392.36 KiB
5d44333	22.85 KiB	411.00 KiB	388.16 KiB
d6116d1	22.85 KiB	415.27 KiB	392.42 KiB
f1eae65	22.85 KiB	410.99 KiB	388.14 KiB