Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Shorten SentryFrame init #3375

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Conversation

philipphofmann
Copy link
Member

@philipphofmann philipphofmann commented Nov 3, 2023

#skip-changelog

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #3375 (1896855) into main (5f8ee7a) will decrease coverage by 0.003%.
The diff coverage is 100.000%.

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #3375       +/-   ##
=============================================
- Coverage   89.276%   89.274%   -0.003%     
=============================================
  Files          500       500               
  Lines        54739     54746        +7     
  Branches     19644     19647        +3     
=============================================
+ Hits         48869     48874        +5     
+ Misses        5002      4889      -113     
- Partials       868       983      +115     
Files Coverage Δ
Sources/Sentry/SentryFrame.m 100.000% <100.000%> (ø)

... and 34 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f8ee7a...1896855. Read the comment docs.

Copy link

github-actions bot commented Nov 3, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1244.63 ms 1252.86 ms 8.23 ms
Size 22.85 KiB 411.93 KiB 389.08 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
a176fc4 1250.29 ms 1257.88 ms 7.59 ms
257c2a9 1231.45 ms 1252.12 ms 20.67 ms
6943de0 1237.67 ms 1247.12 ms 9.45 ms
7419285 1209.53 ms 1244.72 ms 35.19 ms
fd6a31c 1204.73 ms 1222.34 ms 17.61 ms
98cca71 1199.08 ms 1227.36 ms 28.28 ms
9cc7e7c 1228.90 ms 1237.96 ms 9.06 ms
1db04d8 1250.20 ms 1258.12 ms 7.92 ms
afd1a08 1207.78 ms 1223.44 ms 15.66 ms
d8eb419 1221.91 ms 1253.62 ms 31.71 ms

App size

Revision Plain With Sentry Diff
a176fc4 22.84 KiB 403.24 KiB 380.39 KiB
257c2a9 20.76 KiB 401.36 KiB 380.60 KiB
6943de0 20.76 KiB 393.33 KiB 372.57 KiB
7419285 20.76 KiB 432.99 KiB 412.22 KiB
fd6a31c 20.76 KiB 436.50 KiB 415.74 KiB
98cca71 22.85 KiB 411.14 KiB 388.29 KiB
9cc7e7c 22.84 KiB 403.13 KiB 380.29 KiB
1db04d8 20.76 KiB 435.50 KiB 414.74 KiB
afd1a08 22.84 KiB 402.57 KiB 379.72 KiB
d8eb419 22.85 KiB 408.87 KiB 386.02 KiB

@philipphofmann philipphofmann merged commit bbcbaff into main Nov 6, 2023
@philipphofmann philipphofmann deleted the ref/shorten-frame-init branch November 6, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants