Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: move decl/impl from SentryEvent (MetricKit) to SenryEvent .h/.m … #3240

Conversation

armcknight
Copy link
Member

Another conversion of a category to interface extension (see #3236 for elaboration)

This also moved the extension interface and implementation to SentryEvent instead of being hidden in SentryMetricKitIntegration. It also declared isMetricKitEvent as a method since that's what it actually is, and converted callsites to use method syntax.

#skip-changelog

@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #3240 (76c2c08) into main (01a28a9) will increase coverage by 0.047%.
The diff coverage is 100.000%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #3240       +/-   ##
=============================================
+ Coverage   89.112%   89.159%   +0.047%     
=============================================
  Files          502       502               
  Lines        54118     54104       -14     
  Branches     19429     19419       -10     
=============================================
+ Hits         48226     48239       +13     
+ Misses        5029      5007       -22     
+ Partials       863       858        -5     
Files Changed Coverage Δ
Sources/Sentry/SentryMetricKitIntegration.m 99.578% <ø> (-0.027%) ⬇️
Sources/Sentry/SentryEvent.m 98.473% <100.000%> (+0.212%) ⬆️
Sources/Sentry/SentryScreenshotIntegration.m 90.697% <100.000%> (ø)
Sources/Sentry/SentryViewHierarchyIntegration.m 100.000% <100.000%> (ø)
...grations/MetricKit/SentryMetricKitEventTests.swift 100.000% <100.000%> (ø)

... and 10 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01a28a9...76c2c08. Read the comment docs.

Copy link
Contributor

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@armcknight armcknight merged commit b9d59f7 into main Aug 28, 2023
@armcknight armcknight deleted the armcknight/ref/convert-SentryEvent-MetricKit-category-to-interface-extension branch August 28, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants