Fix building iOS with Carthage #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes building in the latest Xcode
|
@soffes Looks like we did similar fixes at the same time 😇 Yours, however, does a bit more so we will go with yours 👌 |
|
@soffes Just realized tests aren't running with these changes now 😬 I'm getting the following error when trying to run them... Any ideas? I believe this is something to do with removing the KSCrash Xcode project that was removed as a reference? |
armcknight
added a commit
that referenced
this pull request
Oct 13, 2022
it was disabled in the unit tests but not in the iOS-Swift scheme for its UI tests fail #1: https://github.com/getsentry/sentry-cocoa/actions/runs/3238645664/jobs/5307090889#step:4:1143 fail #2: https://github.com/getsentry/sentry-cocoa/actions/runs/3238645664/jobs/5307223688#step:4:1161 pass on rerun #3: https://github.com/getsentry/sentry-cocoa/actions/runs/3238645664/jobs/5307687742
philipphofmann
pushed a commit
that referenced
this pull request
Oct 14, 2022
* disable flaky test_DataConsistency_readUrl_disabled it was disabled in the unit tests but not in the iOS-Swift scheme for its UI tests fail #1: https://github.com/getsentry/sentry-cocoa/actions/runs/3238645664/jobs/5307090889#step:4:1143 fail #2: https://github.com/getsentry/sentry-cocoa/actions/runs/3238645664/jobs/5307223688#step:4:1161 pass on rerun #3: https://github.com/getsentry/sentry-cocoa/actions/runs/3238645664/jobs/5307687742 * disable flaky unit tests - `testGetRequest_SpanCreatedAndBaggageHeaderAdded` fails in https://github.com/getsentry/sentry-cocoa/actions/runs/3238645664/jobs/5307104221#step:9:49 and passes in subsequent try in https://github.com/getsentry/sentry-cocoa/actions/runs/3238645664/jobs/5307688649 - `testFlush_CalledSequentially_BlocksTwice` fails in https://github.com/getsentry/sentry-cocoa/actions/runs/3238645664/jobs/5307104166#step:9:39 and passes in subsequent try in https://github.com/getsentry/sentry-cocoa/actions/runs/3238645664/jobs/5307688591 * disable flaky testANRDetected_UpdatesAppStateToTrue fails in https://github.com/getsentry/sentry-cocoa/actions/runs/3239188699/jobs/5308324227#step:9:39 and passes after retry in https://github.com/getsentry/sentry-cocoa/actions/runs/3239188699/jobs/5320658454 * rename to add _disabled suffix * fix skiipped test names with _disabled suffixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mac still doesn't work with Carthage because KSCrash doesn't work build for Mac with Carthage.