Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Use dispatch queue in dependency container #2833

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

philipphofmann
Copy link
Member

Avoid allocating one extra dispatch queue in the dependency container.

#skip-changelog

Avoid allocating one extra dispatch queue in the dependency container.
@@ -8,7 +8,6 @@
#import <SentryDebugImageProvider.h>
#import <SentryDefaultCurrentDateProvider.h>
#import <SentryDependencyContainer.h>
#import <SentryDispatchQueueWrapper.h>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We imported this header twice.

@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Merging #2833 (a409663) into main (fb53d97) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2833      +/-   ##
==========================================
- Coverage   81.33%   81.30%   -0.04%     
==========================================
  Files         258      258              
  Lines       24131    24126       -5     
  Branches    10708    10703       -5     
==========================================
- Hits        19628    19615      -13     
- Misses       4005     4012       +7     
- Partials      498      499       +1     
Impacted Files Coverage Δ
Sources/Sentry/SentryDependencyContainer.m 92.63% <100.00%> (ø)

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb53d97...a409663. Read the comment docs.

@github-actions
Copy link

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1246.80 ms 1250.39 ms 3.59 ms
Size 20.76 KiB 425.80 KiB 405.04 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
8f397a7 1251.82 ms 1268.34 ms 16.52 ms
6ad07ae 1240.76 ms 1242.98 ms 2.22 ms
06548c0 1225.58 ms 1244.70 ms 19.12 ms
cb2eefe 1222.04 ms 1243.04 ms 21.00 ms
28333b6 1186.29 ms 1225.18 ms 38.89 ms
d253cdf 1231.61 ms 1259.52 ms 27.91 ms
ddc9b9a 1210.00 ms 1234.18 ms 24.18 ms
bd2afa6 1245.24 ms 1263.18 ms 17.94 ms
8f397a7 1219.12 ms 1236.67 ms 17.55 ms
371db89 1226.40 ms 1251.54 ms 25.14 ms

App size

Revision Plain With Sentry Diff
8f397a7 20.76 KiB 420.55 KiB 399.79 KiB
6ad07ae 20.76 KiB 424.69 KiB 403.93 KiB
06548c0 20.76 KiB 427.35 KiB 406.59 KiB
cb2eefe 20.76 KiB 419.62 KiB 398.86 KiB
28333b6 20.76 KiB 424.69 KiB 403.93 KiB
d253cdf 20.76 KiB 427.66 KiB 406.90 KiB
ddc9b9a 20.76 KiB 420.40 KiB 399.64 KiB
bd2afa6 20.76 KiB 420.55 KiB 399.79 KiB
8f397a7 20.76 KiB 420.55 KiB 399.79 KiB
371db89 20.76 KiB 427.31 KiB 406.55 KiB

@philipphofmann philipphofmann merged commit cce35c6 into main Mar 24, 2023
@philipphofmann philipphofmann deleted the ref/dependency-container-dispatch-queue branch March 24, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants