Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: highlight buttons that are tapped so it's more obvious what's happening in UI test run videos #2827

Closed

Conversation

armcknight
Copy link
Member

I was trying to debug some UI test failures in sauce labs and couldn't tell what was happening in the videos.

#skip-changelog

@github-actions
Copy link

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1222.32 ms 1251.87 ms 29.55 ms
Size 20.76 KiB 425.81 KiB 405.04 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
28333b6 1247.29 ms 1262.51 ms 15.22 ms
561fa74 1243.27 ms 1260.62 ms 17.35 ms
8f397a7 1236.76 ms 1256.76 ms 20.00 ms
d10ae0c 1250.02 ms 1253.74 ms 3.72 ms
7bc3c0d 1222.86 ms 1244.90 ms 22.04 ms
ad7cec6 1203.22 ms 1224.74 ms 21.52 ms
7fb7afb 1235.00 ms 1256.81 ms 21.81 ms
78d5983 1229.98 ms 1245.60 ms 15.62 ms
443723a 1205.24 ms 1220.52 ms 15.28 ms
eaa1002 1205.50 ms 1235.08 ms 29.58 ms

App size

Revision Plain With Sentry Diff
28333b6 20.76 KiB 424.69 KiB 403.93 KiB
561fa74 20.76 KiB 427.23 KiB 406.46 KiB
8f397a7 20.76 KiB 420.55 KiB 399.79 KiB
d10ae0c 20.76 KiB 419.86 KiB 399.10 KiB
7bc3c0d 20.76 KiB 427.36 KiB 406.59 KiB
ad7cec6 20.76 KiB 427.32 KiB 406.55 KiB
7fb7afb 20.76 KiB 419.69 KiB 398.94 KiB
78d5983 20.76 KiB 427.80 KiB 407.04 KiB
443723a 20.76 KiB 414.44 KiB 393.68 KiB
eaa1002 20.76 KiB 423.19 KiB 402.43 KiB

@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Merging #2827 (3947e35) into main (9e96fd6) will increase coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2827      +/-   ##
==========================================
+ Coverage   81.36%   81.37%   +0.01%     
==========================================
  Files         258      258              
  Lines       24140    24145       +5     
  Branches    10717    10712       -5     
==========================================
+ Hits        19641    19649       +8     
+ Misses       4004     4000       -4     
- Partials      495      496       +1     

see 10 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e96fd6...3947e35. Read the comment docs.

Copy link
Contributor

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Idea.
I wish we could find a more universal solution that would work for every button without the need to call highlightButton every time.

@philipphofmann
Copy link
Member

@armcknight, I prefer enabling this option via an environment variable or something only for the UI tests. Users often check this sample app when trying Sentry for the first time. Having every button highlighted blue kind of looks weird to me.

@armcknight
Copy link
Member Author

Maybe I will convert everything to table views in a later refactor as mentioned in #2828 (comment) so that we get the default highlight behavior.

With that, I'd be fine to just close this PR.

@armcknight armcknight closed this Mar 24, 2023
@armcknight armcknight deleted the armcknight/test/highlight-sample-app-buttons branch June 14, 2023 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants