Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable flaky testStartWithConfigureOptions #2805

Conversation

armcknight
Copy link
Member

@armcknight armcknight commented Mar 16, 2023

Failed in https://github.com/getsentry/sentry-cocoa/actions/runs/4440291597/jobs/7793934097#step:11:30

Passed in the second attempt. No changes to source in that PR.

I've seen it a few times now so I opened this PR and related flaky test issue.

#skip-changelog

@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Merging #2805 (3acacb9) into main (06548c0) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2805      +/-   ##
==========================================
- Coverage   81.28%   81.27%   -0.01%     
==========================================
  Files         259      259              
  Lines       24309    24309              
  Branches    10791    10788       -3     
==========================================
- Hits        19759    19757       -2     
- Misses       4050     4053       +3     
+ Partials      500      499       -1     

see 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06548c0...3acacb9. Read the comment docs.

@brustolin
Copy link
Contributor

I dont know. This is the most used entry point for sentry.
I think it would be a priority to fix this test.

@philipphofmann
Copy link
Member

The logs show

Test Case '-[SentryTests.SentrySDKTests testStartWithConfigureOptions]' started.
2023-03-16 18:25:57.064888+0000 xctest[11057:43909] [Sentry] [debug] [SentryFileManager:659] SentryFileManager.cachePath: /Users/runner/Library/Developer/CoreSimulator/Devices/2B9B95AF-007F-4C91-A5B5-E9CF4FA74E07/data/Library/Caches
2023-03-16 18:25:57.065184+0000 xctest[11057:43909] [Sentry] [debug] [SentryFileManager:242] Deleting /Users/runner/Library/Developer/CoreSimulator/Devices/2B9B95AF-007F-4C91-A5B5-E9CF4FA74E07/data/Library/Caches/io.sentry/1977ed0be0dacf08b85b66faf6d3cb026b11be87/events
2023-03-16 18:25:57.065803+0000 xctest[11057:43909] [Sentry] [debug] [SentryHttpTransport:251] sendAllCachedEnvelopes start.
2023-03-16 18:25:57.066162+0000 xctest[11057:43909] [Sentry] [debug] [SentryHttpTransport:263] No envelopes left to send.
2023-03-16 18:25:57.066302+0000 xctest[11057:43909] [Sentry] [debug] [SentryHttpTransport:342] Finished sending.
2023-03-16 18:25:57.067098+0000 xctest[11057:43909] [Sentry] [debug] [SentryFileManager:490] Moving state /Users/runner/Library/Developer/CoreSimulator/Devices/2023-03-16 18:25:57.067128+0000 xctest[11057:50870] [Sentry] [debug] [SentryFileManager:97] Dispatched deletion of old envelopes from <SentryFileManager: 0x7fbb52b4fad0>
2B9B95AF-007F-4C91-A5B5-E9CF4FA74E07/data/Library/Caches/io.sentry/1977ed0be0dacf08b85b66faf6d3cb026b11be87/app.state to previous /Users/runner/Library/Developer/CoreSimulator/Devices/2B9B95AF-007F-4C91-A5B5-E9CF4FA74E07/data/Library/Caches/io.sentry/1977ed0be0dacf08b85b66faf6d3cb026b11be87/previous.app.state.
2023-03-16 18:25:57.074614+0000 xctest[11057:43909] [Sentry] [debug] [SentryFileManager:242] Deleting /Users/runner/Library/Developer/CoreSimulator/Devices/2B9B95AF-007F-4C91-A5B5-E9CF4FA74E07/data/Library/Caches/io.sentry/1977ed0be0dacf08b85b66faf6d3cb026b11be87/previous.app.state
2023-03-16 18:25:57.075500+0000 xctest[11057:43909] [Sentry] [debug] [SentryFileManager:490] Moving state /Users/runner/Library/Developer/CoreSimulator/Devices/2B9B95AF-007F-4C91-A5B5-E9CF4FA74E07/data/Library/Caches/io.sentry/1977ed0be0dacf08b85b66faf6d3cb022023-03-16 18:25:57.076128+0000 xctest[11057:50870] [Sentry] [warning] [SentryFileManager:178] Could not get NSFileTypeDirectory from /Users/runner/Library/Developer/CoreSimulator/Devices/2B9B95AF-007F-4C91-A5B5-E9CF4FA74E07/data/Library/Caches/io.sentry/timezone.offset
6b11be87/breadcrumbs.1.state to previous /Users/runner/Library/Developer/CoreSimulator/Devices/2B9B95AF-007F-4C91-A5B5-E9CF4FA74E07/data/Library/Caches/io.sentry/1977ed0be0dacf08b85b66faf6d3cb026b11be87/previous.breadcrumbs.1.state.
xctest(11057,0x70000ce1c000) malloc: *** error for object 0x7fbb51fe30f0: pointer being freed was not allocated
xctest(11057,0x70000ce1c000) malloc: *** set a breakpoint in malloc_error_break to debug
2023-03-16 18:25:57.079419+0000 xctest[11057:43909] [Sentry] [debug] [SentryFileManager:242] Deleting /Users/runner/Library/Developer/CoreSimulator/Devices/2B9B95AF-007F-4C91-A5B5-E9CF4FA74E07/data/Library/Caches/io.sentry/1977ed0be0dacf08b85b66faf6d3cb026b11be87/previous.breadcrumbs.1.state

Restarting after unexpected exit, crash, or test timeout in SentrySDKTests.testStartWithConfigureOptions(); s

I agree with @brustolin. This is the main entry point of the SDK. Let's try to fix the underlying issue pointed out in the logs.

@armcknight
Copy link
Member Author

It looks like it's due to the file manager again. I agree this should be a priority to fix though. Mentioned this in #2745.

@armcknight armcknight closed this Mar 20, 2023
@armcknight armcknight deleted the armcknight/test/disable-flaky-testStartWithConfigureOptions branch March 20, 2023 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants