Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable AppHang Tracking by default #2600

Merged
merged 8 commits into from
Jan 16, 2023
Merged

Conversation

philipphofmann
Copy link
Member

@philipphofmann philipphofmann commented Jan 12, 2023

📜 Description

Enable AppHang Tracking by default. Docs PR getsentry/sentry-docs#6064.

💡 Motivation and Context

Enable this feature to provide more value out of the box.

💚 How did you test it?

Unit tests.

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • Review from the native team if needed
  • No breaking changes

🔮 Next steps

Duplicate the released section of 8.0.0-rc1 to have a new
unreleased section new PRs can use.
@github-actions
Copy link

github-actions bot commented Jan 12, 2023

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 29011cf

@github-actions
Copy link

github-actions bot commented Jan 12, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1221.86 ms 1224.71 ms 2.86 ms
Size 20.76 KiB 414.45 KiB 393.69 KiB

Baseline results on branch: 8.0.0

Startup times

Revision Plain With Sentry Diff
bd284cf 1230.53 ms 1259.82 ms 29.29 ms
42bb369 1218.49 ms 1241.98 ms 23.49 ms
e336ea0 1203.71 ms 1231.22 ms 27.51 ms
4e1c9c0 1206.94 ms 1224.20 ms 17.26 ms
b9c9598 1213.80 ms 1249.80 ms 36.00 ms
0188d70 1209.51 ms 1236.18 ms 26.67 ms
17e2418 1245.59 ms 1255.52 ms 9.93 ms
838ad6b 1217.78 ms 1252.10 ms 34.32 ms
e336ea0 1236.49 ms 1255.60 ms 19.11 ms
a0c8696 1239.33 ms 1261.92 ms 22.59 ms

App size

Revision Plain With Sentry Diff
bd284cf 20.75 KiB 405.06 KiB 384.31 KiB
42bb369 20.75 KiB 383.87 KiB 363.12 KiB
e336ea0 20.75 KiB 404.13 KiB 383.37 KiB
4e1c9c0 20.75 KiB 383.87 KiB 363.12 KiB
b9c9598 20.75 KiB 383.77 KiB 363.01 KiB
0188d70 20.76 KiB 405.92 KiB 385.15 KiB
17e2418 20.75 KiB 402.06 KiB 381.31 KiB
838ad6b 20.75 KiB 405.10 KiB 384.34 KiB
e336ea0 20.75 KiB 404.13 KiB 383.37 KiB
a0c8696 20.75 KiB 383.89 KiB 363.14 KiB

Previous results on branch: feat/enable-app-hangs

Startup times

Revision Plain With Sentry Diff
5ae5a2a 1215.76 ms 1247.44 ms 31.68 ms
8e854fd 1201.94 ms 1215.20 ms 13.27 ms
3871f98 1211.86 ms 1240.42 ms 28.56 ms

App size

Revision Plain With Sentry Diff
5ae5a2a 20.76 KiB 414.45 KiB 393.68 KiB
8e854fd 20.76 KiB 414.45 KiB 393.68 KiB
3871f98 20.76 KiB 414.45 KiB 393.68 KiB

@philipphofmann philipphofmann added this to the 8.0.0 milestone Jan 12, 2023
@philipphofmann philipphofmann self-assigned this Jan 12, 2023
@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Merging #2600 (29011cf) into 8.0.0 (23e1220) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##            8.0.0    #2600      +/-   ##
==========================================
+ Coverage   79.67%   79.71%   +0.03%     
==========================================
  Files         244      243       -1     
  Lines       22618    22611       -7     
  Branches    10008    10007       -1     
==========================================
+ Hits        18022    18024       +2     
+ Misses       4145     4135      -10     
- Partials      451      452       +1     
Impacted Files Coverage Δ
Sources/Sentry/SentryOptions.m 96.78% <100.00%> (ø)
Sources/Sentry/NSLocale+Sentry.m 90.00% <0.00%> (-10.00%) ⬇️
Sources/SentryCrash/Recording/Tools/SentryHook.c 86.02% <0.00%> (-1.48%) ⬇️
Sources/Sentry/include/SentryHexAddressFormatter.h
Sources/Sentry/SentryFileManager.m 95.66% <0.00%> (+0.61%) ⬆️
Sources/Sentry/SentryNetworkTracker.m 95.20% <0.00%> (+0.94%) ⬆️
Sources/Sentry/NSDictionary+SentrySanitize.m 100.00% <0.00%> (+4.00%) ⬆️
Sources/Sentry/SentryANRTrackingIntegration.m 100.00% <0.00%> (+5.71%) ⬆️
Sources/Sentry/SentryCrashWrapper.m 84.31% <0.00%> (+5.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23e1220...29011cf. Read the comment docs.

@philipphofmann philipphofmann changed the base branch from chore/changelog-unreleased to 8.0.0 January 13, 2023 13:50
@philipphofmann philipphofmann merged commit f128c16 into 8.0.0 Jan 16, 2023
@philipphofmann philipphofmann deleted the feat/enable-app-hangs branch January 16, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants