-
-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enable AppHang Tracking by default #2600
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Duplicate the released section of 8.0.0-rc1 to have a new unreleased section new PRs can use.
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
bd284cf | 1230.53 ms | 1259.82 ms | 29.29 ms |
42bb369 | 1218.49 ms | 1241.98 ms | 23.49 ms |
e336ea0 | 1203.71 ms | 1231.22 ms | 27.51 ms |
4e1c9c0 | 1206.94 ms | 1224.20 ms | 17.26 ms |
b9c9598 | 1213.80 ms | 1249.80 ms | 36.00 ms |
0188d70 | 1209.51 ms | 1236.18 ms | 26.67 ms |
17e2418 | 1245.59 ms | 1255.52 ms | 9.93 ms |
838ad6b | 1217.78 ms | 1252.10 ms | 34.32 ms |
e336ea0 | 1236.49 ms | 1255.60 ms | 19.11 ms |
a0c8696 | 1239.33 ms | 1261.92 ms | 22.59 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
bd284cf | 20.75 KiB | 405.06 KiB | 384.31 KiB |
42bb369 | 20.75 KiB | 383.87 KiB | 363.12 KiB |
e336ea0 | 20.75 KiB | 404.13 KiB | 383.37 KiB |
4e1c9c0 | 20.75 KiB | 383.87 KiB | 363.12 KiB |
b9c9598 | 20.75 KiB | 383.77 KiB | 363.01 KiB |
0188d70 | 20.76 KiB | 405.92 KiB | 385.15 KiB |
17e2418 | 20.75 KiB | 402.06 KiB | 381.31 KiB |
838ad6b | 20.75 KiB | 405.10 KiB | 384.34 KiB |
e336ea0 | 20.75 KiB | 404.13 KiB | 383.37 KiB |
a0c8696 | 20.75 KiB | 383.89 KiB | 363.14 KiB |
Previous results on branch: feat/enable-app-hangs
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
5ae5a2a | 1215.76 ms | 1247.44 ms | 31.68 ms |
8e854fd | 1201.94 ms | 1215.20 ms | 13.27 ms |
3871f98 | 1211.86 ms | 1240.42 ms | 28.56 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
5ae5a2a | 20.76 KiB | 414.45 KiB | 393.68 KiB |
8e854fd | 20.76 KiB | 414.45 KiB | 393.68 KiB |
3871f98 | 20.76 KiB | 414.45 KiB | 393.68 KiB |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 8.0.0 #2600 +/- ##
==========================================
+ Coverage 79.67% 79.71% +0.03%
==========================================
Files 244 243 -1
Lines 22618 22611 -7
Branches 10008 10007 -1
==========================================
+ Hits 18022 18024 +2
+ Misses 4145 4135 -10
- Partials 451 452 +1
Continue to review full report at Codecov.
|
brustolin
approved these changes
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Enable AppHang Tracking by default. Docs PR getsentry/sentry-docs#6064.
💡 Motivation and Context
Enable this feature to provide more value out of the box.
💚 How did you test it?
Unit tests.
📝 Checklist
🔮 Next steps