Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable Core Data Tracing By Default #2598

Merged
merged 3 commits into from
Jan 13, 2023
Merged

Conversation

philipphofmann
Copy link
Member

@philipphofmann philipphofmann commented Jan 12, 2023

📜 Description

Enable Core Data Tracing By Default. Docs PR getsentry/sentry-docs#6059

💡 Motivation and Context

The feature is GA, and we want to give users more value out of the box by default.

💚 How did you test it?

Was already tested before, but enabling the feature by default is tested by unit tests.

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • Review from the native team if needed
  • No breaking changes

🔮 Next steps

@github-actions
Copy link

github-actions bot commented Jan 12, 2023

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 2a804b6

@github-actions
Copy link

github-actions bot commented Jan 12, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1208.41 ms 1231.48 ms 23.07 ms
Size 20.76 KiB 414.45 KiB 393.68 KiB

Baseline results on branch: 8.0.0

Startup times

Revision Plain With Sentry Diff
ae5ecd1 1226.73 ms 1250.96 ms 24.23 ms
b696ae1 1229.64 ms 1246.94 ms 17.30 ms
b9c9598 1228.57 ms 1251.10 ms 22.53 ms
4a67681 1216.33 ms 1242.29 ms 25.96 ms
5da2d48 1209.52 ms 1232.16 ms 22.64 ms
e336ea0 1192.04 ms 1231.94 ms 39.90 ms
8ff75df 1247.16 ms 1268.26 ms 21.10 ms
bd284cf 1237.24 ms 1261.33 ms 24.08 ms
bc27163 1215.45 ms 1249.46 ms 34.01 ms
9be1db2 1219.42 ms 1245.66 ms 26.24 ms

App size

Revision Plain With Sentry Diff
ae5ecd1 20.75 KiB 383.31 KiB 362.55 KiB
b696ae1 20.75 KiB 383.77 KiB 363.01 KiB
b9c9598 20.75 KiB 383.77 KiB 363.01 KiB
4a67681 20.75 KiB 405.06 KiB 384.31 KiB
5da2d48 20.75 KiB 383.77 KiB 363.01 KiB
e336ea0 20.75 KiB 404.13 KiB 383.37 KiB
8ff75df 20.76 KiB 414.45 KiB 393.69 KiB
bd284cf 20.75 KiB 405.06 KiB 384.31 KiB
bc27163 20.75 KiB 405.10 KiB 384.34 KiB
9be1db2 20.75 KiB 373.94 KiB 353.19 KiB

Previous results on branch: feat/enable-core-data

Startup times

Revision Plain With Sentry Diff
8d8e561 1216.80 ms 1224.40 ms 7.60 ms

App size

Revision Plain With Sentry Diff
8d8e561 20.76 KiB 414.44 KiB 393.68 KiB

@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Merging #2598 (7e3d58f) into 8.0.0 (27db30c) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 7e3d58f differs from pull request most recent head 2a804b6. Consider uploading reports for the commit 2a804b6 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##            8.0.0    #2598      +/-   ##
==========================================
+ Coverage   79.69%   79.72%   +0.03%     
==========================================
  Files         244      244              
  Lines       22610    22623      +13     
  Branches    10002    10013      +11     
==========================================
+ Hits        18018    18036      +18     
+ Misses       4140     4138       -2     
+ Partials      452      449       -3     
Impacted Files Coverage Δ
Sources/Sentry/SentryOptions.m 96.78% <100.00%> (ø)
Sources/Sentry/SentryThreadHandle.cpp 68.30% <0.00%> (-1.10%) ⬇️
Sources/Sentry/SentryLog.m 100.00% <0.00%> (ø)
Sources/Sentry/SentryNetworkTracker.m 95.34% <0.00%> (+0.14%) ⬆️
Sources/Sentry/SentryTracer.m 95.69% <0.00%> (+0.33%) ⬆️
...ryCrash/Recording/Tools/SentryCrashDynamicLinker.c 80.88% <0.00%> (+1.10%) ⬆️
Sources/Sentry/NSDictionary+SentrySanitize.m 100.00% <0.00%> (+4.00%) ⬆️
Sources/Sentry/NSLocale+Sentry.m 100.00% <0.00%> (+10.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b2f602...2a804b6. Read the comment docs.

@philipphofmann philipphofmann merged commit 23e1220 into 8.0.0 Jan 13, 2023
@philipphofmann philipphofmann deleted the feat/enable-core-data branch January 13, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants