fix: Deleting old envelopes for empty DSN #2562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SentryFileManager doesn't append the DSN hash to the basePath if the DSN is nil. We didn't handle this edge case when deleting old envelopes. This is fixed now.
philipphofmann
requested review from
brustolin and
armcknight
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 8.0.0 #2562 +/- ##
==========================================
+ Coverage 79.09% 79.16% +0.07%
==========================================
Files 243 243
Lines 22278 22280 +2
Branches 9854 9855 +1
==========================================
+ Hits 17620 17639 +19
+ Misses 4203 4189 -14
+ Partials 455 452 -3
Continue to review full report at Codecov.
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 1b9c43b | 1227.16 ms | 1244.28 ms | 17.12 ms |
| d914052 | 1236.52 ms | 1251.56 ms | 15.04 ms |
| 4a67681 | 1216.33 ms | 1242.29 ms | 25.96 ms |
| b696ae1 | 1229.64 ms | 1246.94 ms | 17.30 ms |
| f81c2c4 | 1216.88 ms | 1234.42 ms | 17.54 ms |
| bd7cfa8 | 1223.45 ms | 1237.40 ms | 13.95 ms |
| 5da2d48 | 1209.52 ms | 1232.16 ms | 22.64 ms |
| 10f5348 | 1206.36 ms | 1231.18 ms | 24.82 ms |
| 1018de3 | 1244.08 ms | 1254.63 ms | 10.55 ms |
| a0c8696 | 1239.33 ms | 1261.92 ms | 22.59 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 1b9c43b | 20.75 KiB | 404.13 KiB | 383.37 KiB |
| d914052 | 20.75 KiB | 383.89 KiB | 363.13 KiB |
| 4a67681 | 20.75 KiB | 405.06 KiB | 384.31 KiB |
| b696ae1 | 20.75 KiB | 383.77 KiB | 363.01 KiB |
| f81c2c4 | 20.75 KiB | 402.12 KiB | 381.36 KiB |
| bd7cfa8 | 20.75 KiB | 402.12 KiB | 381.36 KiB |
| 5da2d48 | 20.75 KiB | 383.77 KiB | 363.01 KiB |
| 10f5348 | 20.75 KiB | 402.12 KiB | 381.36 KiB |
| 1018de3 | 20.75 KiB | 402.08 KiB | 381.33 KiB |
| a0c8696 | 20.75 KiB | 383.89 KiB | 363.14 KiB |
brustolin
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
The SentryFileManager doesn't append the DSN hash to the basePath if the DSN is nil. We didn't handle this edge case when deleting old envelopes. This is fixed now.
💡 Motivation and Context
Came up while investigating flaky tests, such as https://github.com/getsentry/sentry-cocoa/actions/runs/3792592319.
💚 How did you test it?
Unit tests
📝 Checklist
🔮 Next steps