Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Marks App hang's event stacktrace snapshot as true #2441

Merged
merged 3 commits into from
Nov 24, 2022

Conversation

brustolin
Copy link
Contributor

@brustolin brustolin commented Nov 24, 2022

📜 Description

Marked App hang's event stacktrace snapshot as true.

💡 Motivation and Context

Fixes #2323

💚 How did you test it?

Unit test

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • Review from the native team if needed
  • No breaking changes

🔮 Next steps

@github-actions
Copy link

github-actions bot commented Nov 24, 2022

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Marks App hang's event stacktrace snapshot as true ([#2441](https://github.com/getsentry/sentry-cocoa/pull/2441))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 9a6aa2c

@github-actions
Copy link

github-actions bot commented Nov 24, 2022

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1248.14 ms 1265.55 ms 17.41 ms
Size 20.75 KiB 383.82 KiB 363.07 KiB

Baseline results on branch: 8.0.0

Startup times

Revision Plain With Sentry Diff
2ae7db9 1231.37 ms 1239.98 ms 8.61 ms
c9129b6 1231.86 ms 1270.11 ms 38.25 ms
68094b3 1214.14 ms 1255.09 ms 40.95 ms
e2cec76 1189.48 ms 1229.84 ms 40.36 ms
dcac8ad 1238.82 ms 1247.80 ms 8.98 ms
bbe81cb 1257.25 ms 1272.24 ms 14.99 ms
4dc66f6 1202.59 ms 1228.34 ms 25.75 ms
7eee302 1228.73 ms 1241.94 ms 13.21 ms
f91714d 1222.06 ms 1247.00 ms 24.94 ms
d10145a 1232.65 ms 1257.55 ms 24.90 ms

App size

Revision Plain With Sentry Diff
2ae7db9 20.75 KiB 381.87 KiB 361.12 KiB
c9129b6 20.75 KiB 381.81 KiB 361.06 KiB
68094b3 20.75 KiB 373.94 KiB 353.19 KiB
e2cec76 20.75 KiB 381.81 KiB 361.06 KiB
dcac8ad 20.75 KiB 379.11 KiB 358.36 KiB
bbe81cb 20.75 KiB 381.81 KiB 361.06 KiB
4dc66f6 20.75 KiB 381.81 KiB 361.06 KiB
7eee302 20.75 KiB 374.73 KiB 353.97 KiB
f91714d 20.75 KiB 381.87 KiB 361.12 KiB
d10145a 20.75 KiB 379.12 KiB 358.36 KiB

Previous results on branch: feat/set-Snapshot-for-anr

Startup times

Revision Plain With Sentry Diff
a7c040f 1238.46 ms 1255.18 ms 16.72 ms

App size

Revision Plain With Sentry Diff
a7c040f 20.75 KiB 383.81 KiB 363.06 KiB

@philipphofmann philipphofmann linked an issue Nov 24, 2022 that may be closed by this pull request
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@brustolin brustolin merged commit 040b8d9 into 8.0.0 Nov 24, 2022
@brustolin brustolin deleted the feat/set-Snapshot-for-anr branch November 24, 2022 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AppHangs events should set stacktrace.snapshot true
2 participants