Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: disable flaky tests #2288

Merged
merged 5 commits into from
Oct 14, 2022
Merged

test: disable flaky tests #2288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dd54527
disable flaky test_DataConsistency_readUrl_disabled
armcknight Oct 13, 2022
ffb876c
disable flaky unit tests
armcknight Oct 13, 2022
df73ba7
disable flaky testANRDetected_UpdatesAppStateToTrue
armcknight Oct 13, 2022
0d1d9d9
rename to add _disabled suffix
armcknight Oct 13, 2022
882b666
fix skiipped test names with _disabled suffixes
armcknight Oct 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Samples/iOS-Swift/iOS-Swift.xcodeproj/xcshareddata/xcschemes/iOS-Swift.xcscheme
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,9 @@
<Test
Identifier = "SentryFileIOTrackingIntegrationTests/test_DataConsistency_readPath_disabled()">
</Test>
<Test
Identifier = "SentryFileIOTrackingIntegrationTests/test_DataConsistency_readUrl_disabled()">
</Test>
</SkippedTests>
</TestableReference>
</Testables>
Expand Down
18 changes: 15 additions & 3 deletions Sentry.xcodeproj/xcshareddata/xcschemes/Sentry.xcscheme
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,22 +56,34 @@
</BuildableReference>
<SkippedTests>
<Test
Identifier = "SentryCrashIntegrationTests/testStartUpCrash_CallsFlush()">
Identifier = "SentryCrashIntegrationTests/testStartUpCrash_CallsFlush_disabled()">
</Test>
<Test
Identifier = "SentryFileIOTrackingIntegrationTests/test_DataConsistency_readPath_disabled()">
</Test>
<Test
Identifier = "SentryFileIOTrackingIntegrationTests/test_DataConsistency_readUrl()">
Identifier = "SentryFileIOTrackingIntegrationTests/test_DataConsistency_readUrl_disabled()">
</Test>
<Test
Identifier = "SentryFileIOTrackingIntegrationTests/test_DataConsistency_readUrl_disabled()">
</Test>
<Test
Identifier = "SentryHttpTransportTests/testFlush_CalledSequentially_BlocksTwice_disabled()">
</Test>
<Test
Identifier = "SentryNetworkTrackerIntegrationTests/testGetRequest_SpanCreatedAndBaggageHeaderAdded_disabled()">
</Test>
<Test
Identifier = "SentryNetworkTrackerIntegrationTests/testGetRequest_SpanCreatedAndBaggageHeaderAdded_disabled()">
</Test>
<Test
Identifier = "SentryOutOfMemoryIntegrationTests/testANRDetected_UpdatesAppStateToTrue_disabled()">
</Test>
<Test
Identifier = "SentrySDKIntegrationTestsBase">
</Test>
<Test
Identifier = "SentrySessionGeneratorTests/testSendSessions()">
Identifier = "SentrySessionGeneratorTests/testSendSessions_disabled()">
</Test>
<Test
Identifier = "SentryStacktraceBuilderTests/testAsyncStacktraces_disabled()">
Expand Down
2 changes: 1 addition & 1 deletion Tests/SentryTests/Integrations/OutOfMemory/SentryOutOfMemoryIntegrationTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ class SentryOutOfMemoryIntegrationTests: XCTestCase {
}

#if os(iOS) || os(tvOS) || targetEnvironment(macCatalyst)
func testANRDetected_UpdatesAppStateToTrue() {
func testANRDetected_UpdatesAppStateToTrue_disabled() {
givenInitializedTracker()

Dynamic(sut).anrDetected()
Expand Down
2 changes: 1 addition & 1 deletion ...s/SentryTests/Integrations/Performance/Network/SentryNetworkTrackerIntegrationTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ class SentryNetworkTrackerIntegrationTests: XCTestCase {
XCTAssertEqual(1, breadcrumbs?.count)
}

func testGetRequest_SpanCreatedAndBaggageHeaderAdded() {
func testGetRequest_SpanCreatedAndBaggageHeaderAdded_disabled() {
startSDK()
let transaction = SentrySDK.startTransaction(name: "Test Transaction", operation: "TEST", bindToScope: true) as! SentryTracer
let expect = expectation(description: "Request completed")
Expand Down
2 changes: 1 addition & 1 deletion Tests/SentryTests/Integrations/Session/SentrySessionGeneratorTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ class SentrySessionGeneratorTests: NotificationCenterTestCase {
/**
* Disabled on purpose. This test just sends sessions to Sentry, but doesn't verify that they arrive there properly.
*/
func testSendSessions() {
func testSendSessions_disabled() {
sendSessions(amount: Sessions(healthy: 10, errored: 10, crashed: 3, oom: 1, abnormal: 1))
}

Expand Down
2 changes: 1 addition & 1 deletion Tests/SentryTests/Networking/SentryHttpTransportTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -644,7 +644,7 @@ class SentryHttpTransportTests: XCTestCase {
assertFlushBlocksAndFinishesSuccessfully()
}

func testFlush_CalledSequentially_BlocksTwice() {
func testFlush_CalledSequentially_BlocksTwice_disabled() {
CurrentDate.setCurrentDateProvider(DefaultCurrentDateProvider.sharedInstance())

givenCachedEvents()
Expand Down