Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] React Native #124

Merged
merged 10 commits into from
Feb 7, 2017
Merged

[WIP] React Native #124

merged 10 commits into from
Feb 7, 2017

Conversation

HazAT
Copy link
Member

@HazAT HazAT commented Feb 5, 2017

No description provided.

@HazAT HazAT self-assigned this Feb 5, 2017
@codecov-io
Copy link

codecov-io commented Feb 5, 2017

Codecov Report

Merging #124 into master will not impact coverage by -0.3%.

@@            Coverage Diff            @@
##           master     #124     +/-   ##
=========================================
- Coverage   89.47%   89.18%   -0.3%     
=========================================
  Files          31       35      +4     
  Lines        2024     2099     +75     
=========================================
+ Hits         1811     1872     +61     
- Misses        213      227     +14
Impacted Files Coverage Δ
Sources/Stacktrace.swift 92.98% <ø> (+2.81%)
Sources/Sentry+Error.swift 70% <ø> (ø)
Sources/Frame.swift 100% <ø> (ø)
Sources/Thread.swift 95.34% <ø> (ø)
Sources/Sentry.swift 73.52% <ø> (-13.43%)
Sources/CrashReportConverter.swift 98.76% <100%> (ø)
Sources/KSCrashHandler.swift 93.71% <100%> (-0.04%)
Sources/BinaryImage.swift 100% <100%> (ø)
Sources/MemoryAddress.swift 92.3% <100%> (-7.7%)
Sources/ios/SentrySwizzle.swift 64.86% <100%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5df1e7...435613a. Read the comment docs.

@mitsuhiko
Copy link
Member

We could investigate later if it makes sense to cleanly separate some of the RN things out. I think it's not necessary for now though.

@HazAT HazAT merged commit 1b5ded9 into master Feb 7, 2017
@HazAT HazAT deleted the feature/react-native branch February 7, 2017 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants