Fix: Time-of-check time-of-use filesystem race condition (#4473)

* Fix code scanning alert no. 6: Time-of-check time-of-use filesystem race condition Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> * Update CHANGELOG.md * Apply suggestions from code review * Format code --------- Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Co-authored-by: Sentry Github Bot <[email protected]>
getsentry · Oct 30, 2024 · a90f228 · a90f228
1 parent 0c44375
commit a90f228
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,7 @@
 
 - Add option to report uncaught NSExceptions on macOS (#4471)
 - Build visionOS project with static Sentry SDK (#4462)
+- Time-of-check time-of-use filesystem race condition (#4473)
 - Capture all touches with session replay (#4477)
 
 ### Improvements

diff --git a/Sources/SentryCrash/Recording/Tools/SentryCrashFileUtils.c b/Sources/SentryCrash/Recording/Tools/SentryCrashFileUtils.c
@@ -236,18 +236,18 @@ sentrycrashfu_readEntireFile(const char *const path, char **data, int *length, i
     int fd = -1;
     int bytesToRead = maxLength;
 
-    struct stat st;
-    if (stat(path, &st) < 0) {
-        SENTRY_ASYNC_SAFE_LOG_ERROR("Could not stat %s: %s", path, strerror(errno));
-        goto done;
-    }
-
     fd = open(path, O_RDONLY);
     if (fd < 0) {
         SENTRY_ASYNC_SAFE_LOG_ERROR("Could not open %s: %s", path, strerror(errno));
         goto done;
     }
 
+    struct stat st;
+    if (fstat(fd, &st) < 0) {
+        SENTRY_ASYNC_SAFE_LOG_ERROR("Could not fstat %s: %s", path, strerror(errno));
+        goto done;
+    }
+
     if (bytesToRead == 0 || bytesToRead >= (int)st.st_size) {
         bytesToRead = (int)st.st_size;
     } else if (bytesToRead > 0) {