Skip to content

Commit

Permalink
ci: Increase test timeout to 20 minutes
Browse files Browse the repository at this point in the history
We often see GH actions canceling test jobs because they time out. While 20 minutes
is not ideal, it's better than a canceled test job. We will work on improving the test
suite so it runs faster.
  • Loading branch information
philipphofmann committed May 4, 2023
1 parent fd6a31c commit 276b698
Showing 1 changed file with 1 addition and 12 deletions.
13 changes: 1 addition & 12 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ jobs:
unit-tests:
name: Unit ${{matrix.platform}} - Xcode ${{matrix.xcode}} - OS ${{matrix.test-destination-os}}
runs-on: ${{matrix.runs-on}}
timeout-minutes: ${{matrix.timeout-minutes}}
timeout-minutes: 20
needs: build-test-server

strategy:
Expand All @@ -88,49 +88,42 @@ jobs:
platform: 'iOS'
xcode: '13.2.1'
test-destination-os: '13.7'
timeout-minutes: 15

# iOS 14
- runs-on: macos-11
platform: 'iOS'
xcode: '13.2.1'
test-destination-os: '14.5'
timeout-minutes: 15

# iOS 15
- runs-on: macos-12
platform: 'iOS'
xcode: '13.4.1'
test-destination-os: 'latest'
timeout-minutes: 15

# iOS 16
- runs-on: macos-13
platform: 'iOS'
xcode: '14.3'
test-destination-os: 'latest'
timeout-minutes: 15

# macOS 11
- runs-on: macos-11
platform: 'macOS'
xcode: '13.2.1'
test-destination-os: 'latest'
timeout-minutes: 15

# macOS 12
- runs-on: macos-12
platform: 'macOS'
xcode: '13.4.1'
test-destination-os: 'latest'
timeout-minutes: 15

# macOS 13
- runs-on: macos-13
platform: 'macOS'
xcode: '14.3'
test-destination-os: 'latest'
timeout-minutes: 15

# Catalyst. We only test the latest version, as
# the risk something breaking on Catalyst and not
Expand All @@ -139,7 +132,6 @@ jobs:
platform: 'Catalyst'
xcode: '13.4.1'
test-destination-os: 'latest'
timeout-minutes: 15

# MetricKit doesn't exist for tvOS, so we can still run unit tests with
# Xcode 12 for it.
Expand All @@ -148,21 +140,18 @@ jobs:
platform: 'tvOS'
xcode: '12.5.1'
test-destination-os: 'latest'
timeout-minutes: 15

# tvOS 15
- runs-on: macos-12
platform: 'tvOS'
xcode: '13.4.1'
test-destination-os: 'latest'
timeout-minutes: 15

# tvOS 16
- runs-on: macos-13
platform: 'tvOS'
xcode: '14.3'
test-destination-os: 'latest'
timeout-minutes: 15

steps:
- uses: actions/checkout@v3
Expand Down

0 comments on commit 276b698

Please sign in to comment.