test: HttpTransport finish spans for transaction (#4812)

Finish the tracer and the child spans for the transaction envelope, because they are usually finished when passed to the transaction so we avoid potential side effects.
getsentry · Feb 10, 2025 · 18bf9a5 · 18bf9a5
1 parent 67bb6fa
commit 18bf9a5
Showing 1 changed file with 12 additions and 5 deletions.
diff --git a/Tests/SentryTests/Networking/SentryHttpTransportTests.swift b/Tests/SentryTests/Networking/SentryHttpTransportTests.swift
@@ -106,13 +106,20 @@ class SentryHttpTransportTests: XCTestCase {
 
         func getTransactionEnvelope() -> SentryEnvelope {
             let tracer = SentryTracer(transactionContext: TransactionContext(name: "SomeTransaction", operation: "SomeOperation"), hub: nil)
+
+            let child1 = tracer.startChild(operation: "child1")
+            let child2 = tracer.startChild(operation: "child2")
+            let child3 = tracer.startChild(operation: "child3")
+
+            child1.finish()
+            child2.finish()
+            child3.finish()
+
+            tracer.finish()
+
             let transaction = Transaction(
                 trace: tracer,
-                children: [
-                    tracer.startChild(operation: "child1"),
-                    tracer.startChild(operation: "child2"),
-                    tracer.startChild(operation: "child3")
-                ]
+                children: [child1, child2, child3]
             )
 
             let transactionEnvelope = SentryEnvelope(id: transaction.eventId, items: [SentryEnvelopeItem(event: transaction), attachmentEnvelopeItem])