-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(relay): Forward /api/0/relays/* to inner relays #3144
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #3144 +/- ##
=======================================
Coverage 99.01% 99.01%
=======================================
Files 3 3
Lines 203 203
=======================================
Hits 201 201
Misses 2 2 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Alexander Tarasov <[email protected]>
@iambriccardo when deploying this change the relay container simply stops working because it can't connect to the relay container. Isn't the inner relay trying to retrieve the project config from itself now? |
@stayallive can you try switching the upstream in the Relay config from: self-hosted/relay/config.example.yml Line 2 in da06c0f
to |
Actually nvm, the Lines 74 to 77 in da06c0f
Relay should connect to Sentry directly 🤔 |
I see, my relay is connecting to nginx though... this might have changed in the past... let me correct that! |
Okay, user error here. Sorry! I think a few (hundred) releases ago there was some other issue that was solved by connecting relay through nginx, but that has long been not needed anymore and was forgotten to revert. Seems to all be working now connecting straight to sentry! Thanks for the hint! |
This PR updates the
nginx
configuration to forward to inner relays all requests that go to/api/0/relays/*
. The rationale behind this change is that we don't want any more such endpoints to be hit in Sentry (for example when fetching project configs since in getsentry/sentry#72926 we removed the support to return the reduced configuration).