Skip to content

Commit

Permalink
Update 0062-controlling-pii-and-credentials-in-sd-ks.md
Browse files Browse the repository at this point in the history
  • Loading branch information
sl0thentr0py committed Feb 8, 2023
1 parent a9042ee commit af7d0c6
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion text/0062-controlling-pii-and-credentials-in-sd-ks.md
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ def capture_event(self, event):
if not config.send_default_pii:
scrubbed_event = event_scrubber.scrub_event(event)

new_event = before_send(event)
new_event = before_send(scrubbed_event)
# ... existing logic


Expand Down Expand Up @@ -205,3 +205,11 @@ irrespective of `send_default_pii` and stuff in `pii_denylist` is only scrubbed

* What issues are out of scope for this RFC but are known?
* More advanced scrubbing such as regex detection within a value is out of scope

# Conclusion

For implementation of the scrubber, we will go with Option B since a recursive Option A seems infeasible in most SDKs.
The first MVP will be done in `sentry-python` and we will also include Option C (separate always-on security denylist) for now.
If the implementation has too much complexity, we can debate again during code review and simplify.
Once `sentry-python` is shipped with a scrubber, develop docs will be updated and other high prio SDKs can port the implementation.

0 comments on commit af7d0c6

Please sign in to comment.