-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add data
and api_target
fields to ResponseContext
and scrub graphql
bodies.
#2141
Conversation
Only if we allow SDKs to send multiple formats that have to be normalized into one. When in doubt, I would say no.
This would be the function to hook into. It already takes care of normalizing cookies: relay/relay-general/src/store/normalize/contexts.rs Lines 180 to 200 in 5d764fc
Default scrubbing runs automatically because of
Use cargo install cargo-insta
cargo insta test
cargo insta review |
@jjbayer this PR should be good to go, I've updated the PR description. |
data
and api_target
fields to Response Context and scrub graphql
bodies
data
and api_target
fields to Response Context and scrub graphql
bodiesdata
and api_target
fields to ResponseContext
and scrub graphql
bodies.
…into chore/add-response-data
`api_target` was added in getsentry/relay#2141, this ensures that it gets picked up by the event serializer.
PR for https://github.com/getsentry/rfcs/blob/choregraphql-errors/text/0087-graphql-errors.md
Request#api_target
which is the API target used for advanced data scrubbing, a marker of the type of the request.Response#data
is similar toRequest#data
.Response#inferred_content_type
is similar toRequest#inferred_content_type
.process_event
for the PII processor scrubbing variables from a GraphQL error based on theRequest#api_target
.