meta: update 2023-09-28 #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer versions of LSS include support for RISC-V. Fixed: fuchsia:125946 Change-Id: Iab65174e9a5f2a7075faadd34dc54b0c23ce3da4 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4510030 Reviewed-by: Joshua Peraza <[email protected]>
Fuchsia AddressSanitizer tests were failing because of unaligned memory access in several unit tests. Fixed: fuchsia:125877 Change-Id: If577ea9b7be24ef40865a637d8f6b6d94daaeb67 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4510016 Reviewed-by: Joshua Peraza <[email protected]>
Links to/from run_with_crashpad.md were broken due to a location change. Change-Id: I5bb6d1f945bd22d9e55affa60909aa3b58e532bc Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4544457 Reviewed-by: Mark Mentovai <[email protected]>
…en allocators. This test only change should improve flake on iOS XCUITests. try_free_default can receive a pointer which doesn't belong to the allocator and claimed_address may not be implemented in specified zone. Add fallbacks for both. This logic is identical to the Chromium equivalent shim in base/allocator/partition_allocator/shim/allocator_shim_default_dispatch_to_mac_zoned_malloc.cc Bug:b/270620301 Change-Id: I4a788d4fbc7b324caff18e41618a5f999b4b8d4e Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4549684 Reviewed-by: Mark Mentovai <[email protected]>
Update to a version of mini_chromium that supports RISCV64. Bug: fuchsia:127655 Tested: `python build/run_tests.py` for Linux target Change-Id: I872e5e79933eb8f9b9fe7f4ae243ee9bb04c14b0 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4563254 Reviewed-by: Mark Mentovai <[email protected]>
- Stop overloading introspect (or implement this in the future) - Store each overridden allocation zone and correctly direct calls to the requested zone. Change-Id: I7294e476bb683149acc61419b095ec0e1098781b Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4574037 Reviewed-by: Joshua Peraza <[email protected]>
Mac OS X Server has been discontinued as a separate operating system flavor since 10.6. Current minimal requirements for both Crashpad and Chromium are above that. Change-Id: Ia9063be2e55a48e45d9f9974ac2e51bac004f37d Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4584570 Reviewed-by: Mark Mentovai <[email protected]>
This lays groundwork for floating point registers to also be included in RISC-V CPU context. Bug: fuchsia:5496 Tested: `fx test crashpad` Change-Id: I6230f146f955ac27f053f670f7f45dfff3560d02 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4594586 Reviewed-by: Mark Mentovai <[email protected]>
UBSan is detecting a function type mismatch in this test. This is because TestModule_GetCrashpadInfo returns a TestCrashpadInfo* but the function expectes to return a CrashpadInfo*. Structurally, the TestCrashpadInfo struct is meant to replicate a CrashpadInfo byte-for-byte, but there's no relationship between the types. Bug: fxbug.dev/128274 Change-Id: I7b02ca802e55274116d46513b3aa6dc998f6d292 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4599482 Reviewed-by: Mark Mentovai <[email protected]>
Only RV64GC is supported. Bug: fuchsia:127655 Tested: `python build/run_tests.py` on RISC-V emulator Tested: Created minidump via self-induced crash on RISC-V emulator, ran through Breakpad stackwalker Change-Id: I713797cd623b0a758269048e01696cbce502ca6c Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4581050 Reviewed-by: Joshua Peraza <[email protected]>
Only RV64GC is supported. RISC-V Fuchsia is not able to serve packages yet so unit testing is not possible. Bug: fuchsia:127655 Tested: `crasher` with crashpad added to crashsvc, ran minidump through Breakpad stackwalker Change-Id: I1b6d79128759281aee348e333ea15434ab397001 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4602412 Reviewed-by: Mark Mentovai <[email protected]> Reviewed-by: Joshua Peraza <[email protected]>
Fuchsia does its own storage and upload now, so crashpad_database_util is no longer relevant to Fuchsia. Tested: Compiled for and in Fuchsia. Verified crashpad_database_util artifacts no longer produced. Change-Id: Ie20bb9b308b77bdd39924f5fe70f182c5c2a0782 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4610969 Reviewed-by: Joshua Peraza <[email protected]>
Fuchsia migrated issue tracking to fxbug.dev. It appears that DX-1193 did not get migrated. Fixed: 121707 Change-Id: I4a7fdf00aed223fedd8b66df87647a29139782a1 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4616910 Reviewed-by: Joshua Peraza <[email protected]>
Fuchsia devices are failing to read floating point context for ARM because floating point registers are in the vector context for ARM. This CL prevents warning logs from being emitted in this situation. Fixed: fuchsia:129171 Tested: `fx shell crasher` @ 659207de7293cb30 Change-Id: I1d8d928da122aeb1bc4ac66b789cb638969d0fdf Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4617960 Reviewed-by: Joshua Peraza <[email protected]>
Something in how python is launching these tests changed and means that although fastfails in fastfail_test_program launch WerFault it is not looking for or finding the registered module, so crashpad_wer.dll isn't being loaded, so no crashes are there to be analyzed. Run individually the test programs do produce a crash, and Chrome continues to catch fast fails. Bug: crashpad:458 Change-Id: I52a6aa7aefb02d393c93c2c43ec67fc92b2bd0b0 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4637536 Commit-Queue: Alex Gough <[email protected]> Reviewed-by: Mark Mentovai <[email protected]>
Some versions of python call SetErrorMode which disables WerFault handling for the fastfail test programs. We can set this to a useful value, allowing these tests to run again locally. This does not enable the tests on the bots as they continue to fail. Bug: crashpad:458 Change-Id: Ibdd2f92ed872bd76490db32dccb2257dd91f8280 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4641231 Reviewed-by: Mark Mentovai <[email protected]> Commit-Queue: Alex Gough <[email protected]>
Windows claims that heap corruption crashes are passed to Windows Error Reporting but they are not, they are swallowed and the process is simply terminated. WerFault.exe does not run. We can however intercept these crashes using a vectored exception handler which forwards STATUS_HEAP_CORRUPTION to the normal crash handler. Adds an end-to-end test. Bug: 2515 Change-Id: I2e1361dacef6fd03ea0f00327fee0b05a0c4899e Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4637533 Commit-Queue: Alex Gough <[email protected]> Reviewed-by: Joshua Peraza <[email protected]>
The gen_build_defs.py file is lightly modified from the original one in https://source.chromium.org/chromium/chromium/src/+/main:build/fuchsia/gen_build_defs.py to accommodate for the fact that the SDK gets downloaded into a different folder in crashpad Bug: chromium:1432399 Change-Id: I2c5a5337220b6aca138ca6eb1c37895ca32e72cd Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4600615 Commit-Queue: Chong Gu <[email protected]> Reviewed-by: Joshua Peraza <[email protected]>
See https://chromium.googlesource.com/chromium/src/+/main/docs/mac/arc.md for information about this conversion. Bug: chromium:1280726 Change-Id: I9ed10e9a255eb6b13035b05bcc587c4b6cb7b78e Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4651106 Reviewed-by: Mark Mentovai <[email protected]> Commit-Queue: Mark Mentovai <[email protected]> Reviewed-by: Mark Mentovai <[email protected]>
Bug: chromium:1459865 Change-Id: I28d5caa739c5b59f4af1f062616443aa16fadfa1 Fixed: chromium:1459862 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4663174 Reviewed-by: Mark Mentovai <[email protected]> Commit-Queue: Mark Mentovai <[email protected]>
Bug: 93344 Change-Id: Id794e3c79983b4c2352842edfe73a81ad3958b6e Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4676565 Commit-Queue: Clayton McCray <[email protected]> Commit-Queue: Francois Rousseau <[email protected]> Reviewed-by: Francois Rousseau <[email protected]>
ARC is now enabled by default in Chromium, so enabling it explicitly in Crashpad is redundant. Bug: chromium:733237 Change-Id: I59dd863c0f8e7e16e88b6daccc5f900829c0cec5 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4721646 Reviewed-by: Mark Mentovai <[email protected]> Commit-Queue: Mark Mentovai <[email protected]> Commit-Queue: Avi Drissman <[email protected]>
CaptureContext isn't actually used on Fuchsia and there is a desire to remove `ucontext_t` from Fuchsia as it isn't a real concept on Fuchsia and was only added as a placeholder. Moreover, `ucontext_t` won't ever be added to Fuchsia for RISC-V. Bug: fuchsia:123052 Fixed: fuchsia:131112 Fixed: fuchsia:127655 Tested: `fx test crashpad` on core.x64 emulator Tested: `fx test crashpad` on ARM64 device Tested: `fx shell crasher` @ 16b19a9891978487 on ARM64 device, ran through Breakpad stackwalker locally as well Tested: `fx build crashpad_tests` for minimal.riscv64 Change-Id: I4695054426df78a9deff8c9ea9c478b5bf9701b1 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4717085 Reviewed-by: Mark Mentovai <[email protected]> Commit-Queue: Thomas Gales <[email protected]>
A recent CL [1] broke Fuchsia's Crashpad roller due to duplicate build argument declarations. This CL ensures that sysroot.gni is only imported once. [1] https://chromium-review.googlesource.com/c/chromium/mini_chromium/+/4651973 Fixed: fuchsia:131454 Change-Id: Idcf6ac65cdffee2c9a9551559a8aab0063044428 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4743381 Reviewed-by: Joshua Peraza <[email protected]> Commit-Queue: Thomas Gales <[email protected]>
SetLastChanceExceptionHandler sets a callback to be called after a crash has been reported. Returning true from this callback will not reraise the signal so the execution can continue. This will be used to implement permissive MTE mode, which will continue execution after a MTE crash. Bug: chromium:1467915 Change-Id: I93a28ceea921fe977805482cf47c07643ca6133c Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4707688 Reviewed-by: Robert Sesek <[email protected]> Commit-Queue: Keishi Hattori <[email protected]>
… mode" This reverts commit b1e66e3. Reason for revert: test was flaky on Android bot Original change's description: > Add SetLastChanceExceptionHandler to implement permissive MTE mode > > SetLastChanceExceptionHandler sets a callback to be called after a > crash has been reported. Returning true from this callback will > not reraise the signal so the execution can continue. This will be > used to implement permissive MTE mode, which will continue execution > after a MTE crash. > > Bug: chromium:1467915 > Change-Id: I93a28ceea921fe977805482cf47c07643ca6133c > Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4707688 > Reviewed-by: Robert Sesek <[email protected]> > Commit-Queue: Keishi Hattori <[email protected]> Bug: chromium:1467915 Change-Id: Id815a780b576088974101117a4587adec64cfe8c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4750459 Commit-Queue: Keishi Hattori <[email protected]> Bot-Commit: Rubber Stamper <[email protected]>
ARC is now enabled by default, so there’s no need to enforce it against files being put into non-ARC targets. Bug: chromium:1468376 Change-Id: I58bbb4d1736293a6e9977954ce932dcfe2bafa54 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4750419 Reviewed-by: Mark Mentovai <[email protected]> Commit-Queue: Mark Mentovai <[email protected]>
…aeddcb (3 commits) https://chromium.googlesource.com/chromium/mini_chromium/+log/e009af846ef4..d1baeddcb8de $ git log e009af846..d1baeddcb --date=short --no-merges --format='%ad %ae %s' 2023-08-03 pkasting Reorder string_util.h platform-specific #includes to match Chromium. 2023-08-04 rahul.yadav Add base/types/cxx23_to_underlying.h to mini_chromium base 2023-08-03 pkasting Add base::IsAscii(Digit,Whitespace) to mini_chromium. Created with: roll-dep crashpad/third_party/mini_chromium/mini_chromium Change-Id: I93ba6ef4eba235840e18d0981aaaa926da26159a Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4750022 Reviewed-by: Mark Mentovai <[email protected]> Commit-Queue: Peter Kasting <[email protected]>
Bug: chromium:1361094 Change-Id: Ia5dacb9038cd74b5d490282a8070fb4579ebe3ae Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4750179 Reviewed-by: Mark Mentovai <[email protected]> Commit-Queue: Peter Kasting <[email protected]>
This reverts commit ca6d64d. Reason for revert: The changes did not actually fix the problem once combined with the latest changes from mini_chromium. Original change's description: > [fuchsia][mac] Fix build errors > > A recent CL [1] broke Fuchsia's Crashpad roller due to duplicate build > argument declarations. This CL ensures that sysroot.gni is only imported once. > > [1] https://chromium-review.googlesource.com/c/chromium/mini_chromium/+/4651973 > > Fixed: fuchsia:131454 > Change-Id: Idcf6ac65cdffee2c9a9551559a8aab0063044428 > Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4743381 > Reviewed-by: Joshua Peraza <[email protected]> > Commit-Queue: Thomas Gales <[email protected]> Change-Id: Id3dc42484fbd87e242756c8d2889d2e404370ac7 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4753637 Commit-Queue: Thomas Gales <[email protected]> Reviewed-by: Joshua Peraza <[email protected]>
To support linux-arm64 build hosts, use an appropraite build of gn on those systems. To support linux-arm64 targets, this also updates mini_chromium to 2035d204bd0f812ac95a1ed72038e6bdbcfce4a2: 2035d204bd0f Add support for linux-arm64 Change-Id: I04139d9136d36fcb0a15aee2ce0694909d44ae95 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4760265 Reviewed-by: Joshua Peraza <[email protected]>
…2d31ef (1 commit) https://chromium.googlesource.com/chromium/mini_chromium/+log/2035d204bd0f..a722d31ef524 $ git log 2035d204b..a722d31ef --date=short --no-merges --format='%ad %ae %s' 2023-08-07 tgales [fuchsia][mac] Fix build errors Created with: roll-dep crashpad/third_party/mini_chromium/mini_chromium Fixed: fuchsia:131454 Change-Id: I77d9291cb9cd9cdf967761567e27ae9b0b32b98b Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4761366 Reviewed-by: Joshua Peraza <[email protected]> Commit-Queue: Thomas Gales <[email protected]> Reviewed-by: Mark Mentovai <[email protected]>
https://crrev.com/c/4781926 moves PA files to new locations. This updates the filename reference. Bug: chromium:1444927 Change-Id: I7947711055eb444ab5bc28d4e3c6ca2c39a17e04 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4784548 Commit-Queue: Avi Drissman <[email protected]> Reviewed-by: Mark Mentovai <[email protected]>
This CL rolls mini_chromium to pick up the move of a bunch of files to base/apple, and makes changes to adjust. Bug: chromium:1444927 Change-Id: Ib692e2a1628e2c0c8228795eaecdb7f35b1c09fa Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4786387 Reviewed-by: Mark Mentovai <[email protected]> Commit-Queue: Avi Drissman <[email protected]>
This rolls mini_chromium to the version that has more files in base/apple, and adjusts the code to match. Bug: chromium:1444927 Change-Id: I9642698c8c16151bd0aaca7b46745a59d6e5e6d3 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4791121 Reviewed-by: Mark Mentovai <[email protected]> Commit-Queue: Avi Drissman <[email protected]>
Bug: fuchsia:70426 Change-Id: I346b0d4c1bd411ef106fdc36ca4d846d875fceb9 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4753382 Commit-Queue: Mark Mentovai <[email protected]> Reviewed-by: Mark Mentovai <[email protected]>
Bug: chromium:1474628 Change-Id: Ief0efef22759b935045bf0216a313c2de8025403 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4799234 Reviewed-by: Mark Mentovai <[email protected]> Commit-Queue: Avi Drissman <[email protected]>
These are being removed from gtest, so stop using them. Bug: chromium:1474588 Change-Id: I0d42da9f14dad5c5dc17d980146cb289d444dbda Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4803329 Reviewed-by: Mark Mentovai <[email protected]> Commit-Queue: Mike Frysinger <[email protected]>
…39a976 (1 commit) https://chromium.googlesource.com/chromium/mini_chromium/+log/0c540fd5462a..10f39a97650a $ git log 0c540fd54..10f39a976 --date=short --no-merges --format='%ad %ae %s' 2023-08-09 tgales [riscv][android] Add Android RISC-V support Created with: roll-dep crashpad/third_party/mini_chromium/mini_chromium Fixed: fuchsia:128936 Change-Id: Iee194c24b1dd4418e0f882c7e8c96e2c85eaa617 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4824417 Reviewed-by: Joshua Peraza <[email protected]> Commit-Queue: Thomas Gales <[email protected]>
… mode" This is a reland of commit b1e66e3 Original change's description: > Add SetLastChanceExceptionHandler to implement permissive MTE mode > > SetLastChanceExceptionHandler sets a callback to be called after a > crash has been reported. Returning true from this callback will > not reraise the signal so the execution can continue. This will be > used to implement permissive MTE mode, which will continue execution > after a MTE crash. > > Bug: chromium:1467915 > Change-Id: I93a28ceea921fe977805482cf47c07643ca6133c > Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4707688 > Reviewed-by: Robert Sesek <[email protected]> > Commit-Queue: Keishi Hattori <[email protected]> Bug: chromium:1467915 Change-Id: Ibdc18084deb08bccf3c74f688b7d48ff24fe81f9 Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4756235 Reviewed-by: Robert Sesek <[email protected]> Commit-Queue: Keishi Hattori <[email protected]>
This CL adds the Shipped field in READMEs. See the LSC doc at go/lsc-chrome-metadata. Bug: b:285450740 Change-Id: I3dcd5e027f06982f4c2dd98136d3a6d7f6228b4e Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4666416 Reviewed-by: Mark Mentovai <[email protected]> Commit-Queue: Mark Mentovai <[email protected]>
This fixes the following warning during compilation: > process_reader_mac_test.cc:670:7: warning: address of function > '_dyld_shared_cache_contains_path' will always evaluate to 'true' > [-Wpointer-bool-conversion] while still retaining compatibility with pre-macOS 11 runtimes when built with a suitable deployment target. Bug: 461 Change-Id: I61a360e8e02ceb7209c887819a4916a68384b89d Reviewed-on: https://chromium-review.googlesource.com/c/crashpad/crashpad/+/4873433 Reviewed-by: Joshua Peraza <[email protected]> Commit-Queue: Mark Mentovai <[email protected]>
Swatinem
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.